CalibCalorimetry/EcalLaserAnalyzer : gcc 6.0 misleading-indentation warning flags potential bug; with bug fix

[gartung]

/build/cmsbuild/jenkins-workarea/workspace/build-any-ib/w/tmp/BUILDROOT/8258e37281729e179b5af9c3b033d930/opt/cmssw/slc6_amd64_gcc600/cms/cmssw/CMSSW_8_1_X_2016-06-26-2300/src/CalibCalorimetry/EcalLaserAnalyzer/src/MEChannel.cc: In member function 'TString MEChannel::oneLine(int)':
/build/cmsbuild/jenkins-workarea/workspace/build-any-ib/w/tmp/BUILDROOT/8258e37281729e179b5af9c3b033d930/opt/cmssw/slc6_amd64_gcc600/cms/cmssw/CMSSW_8_1_X_2016-06-26-2300/src/CalibCalorimetry/EcalLaserAnalyzer/src/MEChannel.cc:227:7: warning: this 'if' clause does not guard... [-Wmisleading-indentation]
if( ig==ME::iSector ) out+="/S="; out+=_id[ME::iSector];
^~
/build/cmsbuild/jenkins-workarea/workspace/build-any-ib/w/tmp/BUILDROOT/8258e37281729e179b5af9c3b033d930/opt/cmssw/slc6_amd64_gcc600/cms/cmssw/CMSSW_8_1_X_2016-06-26-2300/src/CalibCalorimetry/EcalLaserAnalyzer/src/MEChannel.cc:227:41: note: ...this statement, but the latter is misleadingly indented as if it is guarded by the 'if'
if( ig==ME::iSector ) out+="/S="; out+=_id[ME::iSector];
^~~
/build/cmsbuild/jenkins-workarea/workspace/build-any-ib/w/tmp/BUILDROOT/8258e37281729e179b5af9c3b033d930/opt/cmssw/slc6_amd64_gcc600/cms/cmssw/CMSSW_8_1_X_2016-06-26-2300/src/CalibCalorimetry/EcalLaserAnalyzer/src/MEChannel.cc: In member function 'TString MEChannel::oneWord(int)':
/build/cmsbuild/jenkins-workarea/workspace/build-any-ib/w/tmp/BUILDROOT/8258e37281729e179b5af9c3b033d930/opt/cmssw/slc6_amd64_gcc600/cms/cmssw/CMSSW_8_1_X_2016-06-26-2300/src/CalibCalorimetry/EcalLaserAnalyzer/src/MEChannel.cc:304:7: warning: this 'if' clause does not guard... [-Wmisleading-indentation]
if( ig==ME::iSector ) out+="_S"; out+=_id[ME::iSector];
^~
/build/cmsbuild/jenkins-workarea/workspace/build-any-ib/w/tmp/BUILDROOT/8258e37281729e179b5af9c3b033d930/opt/cmssw/slc6_amd64_gcc600/cms/cmssw/CMSSW_8_1_X_2016-06-26-2300/src/CalibCalorimetry/EcalLaserAnalyzer/src/MEChannel.cc:304:40: note: ...this statement, but the latter is misleadingly indented as if it is guarded by the 'if'
if( ig==ME::iSector ) out+="_S"; out+=_id[ME::iSector];
^~~

[cmsbuild]

A new Pull Request was created by @gartung (Patrick Gartung) for CMSSW_8_1_X.

It involves the following packages:

CalibCalorimetry/EcalLaserAnalyzer

@ghellwig, @cerminar, @cmsbuild, @franzoni, @mmusich, @davidlange6 can you please review it and eventually sign? Thanks.
@ghellwig, @tocheng, @argiro this is something you requested to watch as well.
@slava77, @Degano, @smuzaffar you are the release manager for this.

cms-bot commands are list here #13028

[mmusich]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/13743/console
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/13751/console

[cmsbuild]

+1
Tested at: ae743af
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-15019/13751/summary.html

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-15019/13751/summary.html

[mmusich]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_1_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar

[davidlange6]

+1