CalibTracker/SiStripChannelGain : formatting fix for gcc 6.0 misleading-indentation warning #15022
Conversation
|
A new Pull Request was created by @gartung (Patrick Gartung) for CMSSW_8_1_X. It involves the following packages: CalibTracker/SiStripChannelGain @ghellwig, @cerminar, @cmsbuild, @franzoni, @mmusich, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are list here #13028 |
| @@ -1038,7 +1039,7 @@ SiStripGainFromData::algoAnalyze(const edm::Event& iEvent, const edm::EventSetup | |||
|
|
|||
| for(Trajectory::RecHitContainer::const_iterator rechit = transRecHits.begin(); rechit != transRecHits.end(); ++rechit) | |||
| if ((*rechit)->isValid()) ndof += (*rechit)->dimension(); | |||
| ndof -= 5; | |||
There was a problem hiding this comment.
Is this supposed to be part of the for loop or go after the for loop?
There was a problem hiding this comment.
This piece of code is not used anywhere. Please ignore it.
Cheers,
Alessandro.
On 11 Jul 2016, at 11:29, Marco Musich notifications@github.com wrote:
In CalibTracker/SiStripChannelGain/plugins/SiStripGainFromData.cc #15022 (comment):
@@ -1038,7 +1039,7 @@ SiStripGainFromData::algoAnalyze(const edm::Event& iEvent, const edm::EventSetup
for(Trajectory::RecHitContainer::const_iterator rechit = transRecHits.begin(); rechit != transRecHits.end(); ++rechit) if ((*rechit)->isValid()) ndof += (*rechit)->dimension();
ndof -= 5;—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub https://github.com/cms-sw/cmssw/pull/15022/files/8213e295092f8d3da1c9a54c1c90a73248d8f4c5#r70226662, or mute the thread https://github.com/notifications/unsubscribe/AIK-7gPTCbKtwgR3M2Ga62zShEFhT2dUks5qUgzvgaJpZM4JAT8a.
|
please test |
|
The tests are being triggered in jenkins. |
gartung
changed the title
|
+1 |
cmsbuild
added
alca-approved
fully-signed
and removed
alca-pending
pending-signatures
labels
|
This pull request is fully signed and it will be integrated in one of the next CMSSW_8_1_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar |
|
@dimattia, if not used anywhere we should plan to remove it from CMSSW |
|
+1 |
/build/cmsbuild/jenkins-workarea/workspace/build-any-ib/w/tmp/BUILDROOT/8258e37281729e179b5af9c3b033d930/opt/cmssw/slc6_amd64_gcc600/cms/cmssw/CMSSW_8_1_X_2016-06-26-2300/src/CalibTracker/SiStripChannelGain/plugins/SiStripGainFromData.cc: In member function 'virtual void SiStripGainFromData::algoEndJob()':
/build/cmsbuild/jenkins-workarea/workspace/build-any-ib/w/tmp/BUILDROOT/8258e37281729e179b5af9c3b033d930/opt/cmssw/slc6_amd64_gcc600/cms/cmssw/CMSSW_8_1_X_2016-06-26-2300/src/CalibTracker/SiStripChannelGain/plugins/SiStripGainFromData.cc:624:10: warning: this 'else' clause does not guard... [-Wmisleading-indentation]
else if(tmp_SRun==SRun && tmp_SEvent<SEvent){SEvent=tmp_SEvent;}
^~~~
/build/cmsbuild/jenkins-workarea/workspace/build-any-ib/w/tmp/BUILDROOT/8258e37281729e179b5af9c3b033d930/opt/cmssw/slc6_amd64_gcc600/cms/cmssw/CMSSW_8_1_X_2016-06-26-2300/src/CalibTracker/SiStripChannelGain/plugins/SiStripGainFromData.cc:626:15: note: ...this statement, but the latter is misleadingly indented as if it is guarded by the 'else'
if(tmp_ERun> ERun){ERun=tmp_ERun; EEvent=tmp_EEvent;}
^~
/build/cmsbuild/jenkins-workarea/workspace/build-any-ib/w/tmp/BUILDROOT/8258e37281729e179b5af9c3b033d930/opt/cmssw/slc6_amd64_gcc600/cms/cmssw/CMSSW_8_1_X_2016-06-26-2300/src/CalibTracker/SiStripChannelGain/plugins/SiStripGainFromData.cc:647:7: warning: this 'if' clause does not guard... [-Wmisleading-indentation]
if( I%3650==0 ) printf("Fitting Histograms \t %6.2f%%\n",(100.0_I)/APVsColl.size());I++;
^~
/build/cmsbuild/jenkins-workarea/workspace/build-any-ib/w/tmp/BUILDROOT/8258e37281729e179b5af9c3b033d930/opt/cmssw/slc6_amd64_gcc600/cms/cmssw/CMSSW_8_1_X_2016-06-26-2300/src/CalibTracker/SiStripChannelGain/plugins/SiStripGainFromData.cc:647:91: note: ...this statement, but the latter is misleadingly indented as if it is guarded by the 'if'
if( I%3650==0 ) printf("Fitting Histograms \t %6.2f%%\n",(100.0_I)/APVsColl.size());I++;
^
/build/cmsbuild/jenkins-workarea/workspace/build-any-ib/w/tmp/BUILDROOT/8258e37281729e179b5af9c3b033d930/opt/cmssw/slc6_amd64_gcc600/cms/cmssw/CMSSW_8_1_X_2016-06-26-2300/src/CalibTracker/SiStripChannelGain/plugins/SiStripGainFromData.cc: In member function 'virtual void SiStripGainFromData::algoAnalyze(const edm::Event&, const edm::EventSetup&)':
/build/cmsbuild/jenkins-workarea/workspace/build-any-ib/w/tmp/BUILDROOT/8258e37281729e179b5af9c3b033d930/opt/cmssw/slc6_amd64_gcc600/cms/cmssw/CMSSW_8_1_X_2016-06-26-2300/src/CalibTracker/SiStripChannelGain/plugins/SiStripGainFromData.cc:1039:7: warning: this 'for' clause does not guard... [-Wmisleading-indentation]
for(Trajectory::RecHitContainer::const_iterator rechit = transRecHits.begin(); rechit != transRecHits.end(); ++rechit)
^~~
/build/cmsbuild/jenkins-workarea/workspace/build-any-ib/w/tmp/BUILDROOT/8258e37281729e179b5af9c3b033d930/opt/cmssw/slc6_amd64_gcc600/cms/cmssw/CMSSW_8_1_X_2016-06-26-2300/src/CalibTracker/SiStripChannelGain/plugins/SiStripGainFromData.cc:1041:10: note: ...this statement, but the latter is misleadingly indented as if it is guarded by the 'for'
ndof -= 5;
^~~~