Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CalibTracker/SiStripChannelGain : formatting fix for gcc 6.0 misleading-indentation warning #15022

Merged
merged 1 commit into from Jul 12, 2016
Merged

CalibTracker/SiStripChannelGain : formatting fix for gcc 6.0 misleading-indentation warning #15022

merged 1 commit into from Jul 12, 2016

Conversation

gartung
Copy link
Member

@gartung gartung commented Jun 28, 2016

/build/cmsbuild/jenkins-workarea/workspace/build-any-ib/w/tmp/BUILDROOT/8258e37281729e179b5af9c3b033d930/opt/cmssw/slc6_amd64_gcc600/cms/cmssw/CMSSW_8_1_X_2016-06-26-2300/src/CalibTracker/SiStripChannelGain/plugins/SiStripGainFromData.cc: In member function 'virtual void SiStripGainFromData::algoEndJob()':
/build/cmsbuild/jenkins-workarea/workspace/build-any-ib/w/tmp/BUILDROOT/8258e37281729e179b5af9c3b033d930/opt/cmssw/slc6_amd64_gcc600/cms/cmssw/CMSSW_8_1_X_2016-06-26-2300/src/CalibTracker/SiStripChannelGain/plugins/SiStripGainFromData.cc:624:10: warning: this 'else' clause does not guard... [-Wmisleading-indentation]
else if(tmp_SRun==SRun && tmp_SEvent<SEvent){SEvent=tmp_SEvent;}
^~~~
/build/cmsbuild/jenkins-workarea/workspace/build-any-ib/w/tmp/BUILDROOT/8258e37281729e179b5af9c3b033d930/opt/cmssw/slc6_amd64_gcc600/cms/cmssw/CMSSW_8_1_X_2016-06-26-2300/src/CalibTracker/SiStripChannelGain/plugins/SiStripGainFromData.cc:626:15: note: ...this statement, but the latter is misleadingly indented as if it is guarded by the 'else'
if(tmp_ERun> ERun){ERun=tmp_ERun; EEvent=tmp_EEvent;}
^~
/build/cmsbuild/jenkins-workarea/workspace/build-any-ib/w/tmp/BUILDROOT/8258e37281729e179b5af9c3b033d930/opt/cmssw/slc6_amd64_gcc600/cms/cmssw/CMSSW_8_1_X_2016-06-26-2300/src/CalibTracker/SiStripChannelGain/plugins/SiStripGainFromData.cc:647:7: warning: this 'if' clause does not guard... [-Wmisleading-indentation]
if( I%3650==0 ) printf("Fitting Histograms \t %6.2f%%\n",(100.0_I)/APVsColl.size());I++;
^~
/build/cmsbuild/jenkins-workarea/workspace/build-any-ib/w/tmp/BUILDROOT/8258e37281729e179b5af9c3b033d930/opt/cmssw/slc6_amd64_gcc600/cms/cmssw/CMSSW_8_1_X_2016-06-26-2300/src/CalibTracker/SiStripChannelGain/plugins/SiStripGainFromData.cc:647:91: note: ...this statement, but the latter is misleadingly indented as if it is guarded by the 'if'
if( I%3650==0 ) printf("Fitting Histograms \t %6.2f%%\n",(100.0_I)/APVsColl.size());I++;
^
/build/cmsbuild/jenkins-workarea/workspace/build-any-ib/w/tmp/BUILDROOT/8258e37281729e179b5af9c3b033d930/opt/cmssw/slc6_amd64_gcc600/cms/cmssw/CMSSW_8_1_X_2016-06-26-2300/src/CalibTracker/SiStripChannelGain/plugins/SiStripGainFromData.cc: In member function 'virtual void SiStripGainFromData::algoAnalyze(const edm::Event&, const edm::EventSetup&)':
/build/cmsbuild/jenkins-workarea/workspace/build-any-ib/w/tmp/BUILDROOT/8258e37281729e179b5af9c3b033d930/opt/cmssw/slc6_amd64_gcc600/cms/cmssw/CMSSW_8_1_X_2016-06-26-2300/src/CalibTracker/SiStripChannelGain/plugins/SiStripGainFromData.cc:1039:7: warning: this 'for' clause does not guard... [-Wmisleading-indentation]
for(Trajectory::RecHitContainer::const_iterator rechit = transRecHits.begin(); rechit != transRecHits.end(); ++rechit)
^~~
/build/cmsbuild/jenkins-workarea/workspace/build-any-ib/w/tmp/BUILDROOT/8258e37281729e179b5af9c3b033d930/opt/cmssw/slc6_amd64_gcc600/cms/cmssw/CMSSW_8_1_X_2016-06-26-2300/src/CalibTracker/SiStripChannelGain/plugins/SiStripGainFromData.cc:1041:10: note: ...this statement, but the latter is misleadingly indented as if it is guarded by the 'for'
ndof -= 5;
^~~~

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @gartung (Patrick Gartung) for CMSSW_8_1_X.

It involves the following packages:

CalibTracker/SiStripChannelGain

@ghellwig, @cerminar, @cmsbuild, @franzoni, @mmusich, @davidlange6 can you please review it and eventually sign? Thanks.
@ghellwig, @OlivierBondu, @jlagram, @gbenelli, @tocheng this is something you requested to watch as well.
@slava77, @Degano, @smuzaffar you are the release manager for this.

cms-bot commands are list here #13028

@@ -1038,7 +1039,7 @@ SiStripGainFromData::algoAnalyze(const edm::Event& iEvent, const edm::EventSetup

for(Trajectory::RecHitContainer::const_iterator rechit = transRecHits.begin(); rechit != transRecHits.end(); ++rechit)
if ((*rechit)->isValid()) ndof += (*rechit)->dimension();
ndof -= 5;
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this supposed to be part of the for loop or go after the for loop?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dimattia @boudoul please comment

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mmusich

This piece of code is not used anywhere. Please ignore it.

Cheers,
Alessandro.

On 11 Jul 2016, at 11:29, Marco Musich notifications@github.com wrote:

In CalibTracker/SiStripChannelGain/plugins/SiStripGainFromData.cc #15022 (comment):

@@ -1038,7 +1039,7 @@ SiStripGainFromData::algoAnalyze(const edm::Event& iEvent, const edm::EventSetup

   for(Trajectory::RecHitContainer::const_iterator rechit = transRecHits.begin(); rechit != transRecHits.end(); ++rechit)
      if ((*rechit)->isValid()) ndof += (*rechit)->dimension();  


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub https://github.com/cms-sw/cmssw/pull/15022/files/8213e295092f8d3da1c9a54c1c90a73248d8f4c5#r70226662, or mute the thread https://github.com/notifications/unsubscribe/AIK-7gPTCbKtwgR3M2Ga62zShEFhT2dUks5qUgzvgaJpZM4JAT8a.

@mmusich
Copy link
Contributor

mmusich commented Jun 28, 2016

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 28, 2016

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/13745/console

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@gartung gartung changed the title CalibTracker/SiStripChannelGain : gcc 6.0 misleading-indentation warning flags potential bug; with formatting fix CalibTracker/SiStripChannelGain : formatting fix for gcc 6.0 misleading-indentation warning Jul 1, 2016
@mmusich
Copy link
Contributor

mmusich commented Jul 11, 2016

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_1_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar

@mmusich
Copy link
Contributor

mmusich commented Jul 11, 2016

@dimattia, if not used anywhere we should plan to remove it from CMSSW

@davidlange6
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit c550e8a into cms-sw:CMSSW_8_1_X Jul 12, 2016
@gartung gartung deleted the CalibTracker-SiStripChannelGain-fix-indent-not-guard branch July 20, 2016 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants