Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CalibTracker/SiStripChannelGain : formatting fix for gcc 6.0 misleading-indentation warning #15022

Merged
merged 1 commit into from Jul 12, 2016
Merged

CalibTracker/SiStripChannelGain : formatting fix for gcc 6.0 misleading-indentation warning #15022

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
9 changes: 5 additions & 4 deletions CalibTracker/SiStripChannelGain/plugins/SiStripGainFromData.cc
View file
Open in desktop
Expand Up @@ -620,10 +620,10 @@ SiStripGainFromData::algoEndJob() {

if(SRun==0)SRun = tmp_SRun;

if(tmp_SRun< SRun){SRun=tmp_SRun; SEvent=tmp_SEvent;}
if (tmp_SRun< SRun){SRun=tmp_SRun; SEvent=tmp_SEvent;}
else if(tmp_SRun==SRun && tmp_SEvent<SEvent){SEvent=tmp_SEvent;}

if(tmp_ERun> ERun){ERun=tmp_ERun; EEvent=tmp_EEvent;}
if (tmp_ERun> ERun){ERun=tmp_ERun; EEvent=tmp_EEvent;}
else if(tmp_ERun==ERun && tmp_EEvent>EEvent){EEvent=tmp_EEvent;}

printf("Deleting Current Input File\n");
Expand All @@ -644,7 +644,8 @@ SiStripGainFromData::algoEndJob() {
double* FitResults = new double[5];
I=0;
for(__gnu_cxx::hash_map<unsigned int, stAPVGain*, __gnu_cxx::hash<unsigned int>, isEqual >::iterator it = APVsColl.begin();it!=APVsColl.end();it++){
if( I%3650==0 ) printf("Fitting Histograms \t %6.2f%%\n",(100.0*I)/APVsColl.size());I++;
if( I%3650==0 ) printf("Fitting Histograms \t %6.2f%%\n",(100.0*I)/APVsColl.size());
I++;
stAPVGain* APV = it->second;

int bin = APV_Charge->GetXaxis()->FindBin(APV->Index);
Expand Down Expand Up @@ -1038,7 +1039,7 @@ SiStripGainFromData::algoAnalyze(const edm::Event& iEvent, const edm::EventSetup

for(Trajectory::RecHitContainer::const_iterator rechit = transRecHits.begin(); rechit != transRecHits.end(); ++rechit)
if ((*rechit)->isValid()) ndof += (*rechit)->dimension();
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this supposed to be part of the for loop or go after the for loop?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dimattia @boudoul please comment

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dimattia @boudoul ping

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mmusich

This piece of code is not used anywhere. Please ignore it.

Cheers,
Alessandro.

On 11 Jul 2016, at 11:29, Marco Musich notifications@github.com wrote:

In CalibTracker/SiStripChannelGain/plugins/SiStripGainFromData.cc #15022 (comment):

@@ -1038,7 +1039,7 @@ SiStripGainFromData::algoAnalyze(const edm::Event& iEvent, const edm::EventSetup

   for(Trajectory::RecHitContainer::const_iterator rechit = transRecHits.begin(); rechit != transRecHits.end(); ++rechit)
      if ((*rechit)->isValid()) ndof += (*rechit)->dimension();

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub https://github.com/cms-sw/cmssw/pull/15022/files/8213e295092f8d3da1c9a54c1c90a73248d8f4c5#r70226662, or mute the thread https://github.com/notifications/unsubscribe/AIK-7gPTCbKtwgR3M2Ga62zShEFhT2dUks5qUgzvgaJpZM4JAT8a.

ndof -= 5;
ndof -= 5;
//END TO COMPUTE NDOF FOR TRACKS NO IMPLEMENTED BEFORE 200pre3

HTrackChi2OverNDF->Fill(traj.chiSquared()/ndof);
Expand Down