CommonTools/TrackerMap : fix for bug flagged by gcc 6.0 misleading-indentation warning #15025
Conversation
|
A new Pull Request was created by @gartung (Patrick Gartung) for CMSSW_8_1_X. It involves the following packages: CommonTools/TrackerMap @cvuosalo, @dmitrijus, @cmsbuild, @slava77, @vanbesien, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are list here #13028 |
| c = new TColor(ncolor+100,(Double_t)(red/255.),(Double_t)(green/255.),(Double_t)(blue/255.)); | ||
| vc.push_back(c); |
There was a problem hiding this comment.
Without the curly braces this pushes back a pointer to the last TColor set instead of the new one just created.
|
@cmsbuild please test |
|
The tests are being triggered in jenkins. |
|
-1 Tested at: 198278b You can see the results of the tests here: I found follow errors while testing this PR Failed tests: RelVals
When I ran the RelVals I found an error in the following worklfows: runTheMatrix-results/25202.0_TTbar_13+TTbar_13+DIGIUP15_PU25+RECOUP15_PU25+HARVESTUP15_PU25/step3_TTbar_13+TTbar_13+DIGIUP15_PU25+RECOUP15_PU25+HARVESTUP15_PU25.log |
|
@cmsbuild please test |
|
The tests are being triggered in jenkins. |
cmsbuild
added
tests-pending
tests-started
and removed
tests-rejected
tests-pending
labels
cmsbuild
added
dqm-pending
tests-pending
comparison-pending
and removed
comparison-available
dqm-approved
tests-approved
labels
|
Pull request #15025 was updated. @cvuosalo, @dmitrijus, @cmsbuild, @slava77, @vanbesien, @davidlange6 can you please check and sign again. |
|
@cmsbuild please test |
|
The tests are being triggered in jenkins. |
cmsbuild
added
tests-approved
comparison-available
comparison-pending
and removed
tests-started
comparison-pending
comparison-available
labels
|
+1 Fixing bug with missing braces in The code changes are satisfactory, and Jenkins tests against baseline CMSSW_8_1_X_2016-07-07-1100 show no significant differences, as expected. |
/build/cmsbuild/jenkins-workarea/workspace/build-any-ib/w/tmp/BUILDROOT/8258e37281729e179b5af9c3b033d930/opt/cmssw/slc6_amd64_gcc600/cms/cmssw/CMSSW_8_1_X_2016-06-26-2300/src/CommonTools/TrackerMap/src/TrackerMap.cc: In member function 'void TrackerMap::save_as_fectrackermap(bool, float, float, std::string, int, int)':
/build/cmsbuild/jenkins-workarea/workspace/build-any-ib/w/tmp/BUILDROOT/8258e37281729e179b5af9c3b033d930/opt/cmssw/slc6_amd64_gcc600/cms/cmssw/CMSSW_8_1_X_2016-06-26-2300/src/CommonTools/TrackerMap/src/TrackerMap.cc:1484:9: warning: this 'else' clause does not guard... [-Wmisleading-indentation]
else
^~~~
/build/cmsbuild/jenkins-workarea/workspace/build-any-ib/w/tmp/BUILDROOT/8258e37281729e179b5af9c3b033d930/opt/cmssw/slc6_amd64_gcc600/cms/cmssw/CMSSW_8_1_X_2016-06-26-2300/src/CommonTools/TrackerMap/src/TrackerMap.cc:1486:11: note: ...this statement, but the latter is misleadingly indented as if it is guarded by the 'else'
vc.push_back(c);
^~
/build/cmsbuild/jenkins-workarea/workspace/build-any-ib/w/tmp/BUILDROOT/8258e37281729e179b5af9c3b033d930/opt/cmssw/slc6_amd64_gcc600/cms/cmssw/CMSSW_8_1_X_2016-06-26-2300/src/CommonTools/TrackerMap/src/TrackerMap.cc: In member function 'void TrackerMap::save_as_HVtrackermap(bool, float, float, std::string, int, int)':
/build/cmsbuild/jenkins-workarea/workspace/build-any-ib/w/tmp/BUILDROOT/8258e37281729e179b5af9c3b033d930/opt/cmssw/slc6_amd64_gcc600/cms/cmssw/CMSSW_8_1_X_2016-06-26-2300/src/CommonTools/TrackerMap/src/TrackerMap.cc:1765:2: warning: this 'else' clause does not guard... [-Wmisleading-indentation]
else
^~~~
/build/cmsbuild/jenkins-workarea/workspace/build-any-ib/w/tmp/BUILDROOT/8258e37281729e179b5af9c3b033d930/opt/cmssw/slc6_amd64_gcc600/cms/cmssw/CMSSW_8_1_X_2016-06-26-2300/src/CommonTools/TrackerMap/src/TrackerMap.cc:1767:4: note: ...this statement, but the latter is misleadingly indented as if it is guarded by the 'else'
vc.push_back(c);
^~