bsunanda:Phase2-hgx60 Correct BH geometry... #15055
Conversation
|
@cmsbuild Please test |
|
The tests are being triggered in jenkins. |
|
A new Pull Request was created by @bsunanda for CMSSW_8_1_X. It involves the following packages: DetectorDescription/Core @civanch, @Dr15Jones, @ianna, @mdhildreth, @dmitrijus, @cmsbuild, @vanbesien, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are list here #13028 |
|
@bsunanda , would it be possible to substitute in SimG4Core/Geometry/src/DDG4SolidConverter.cc parameter "s" by something, for example "ss". This is useful to avoid namespace problems with CLHEP. |
|
-1 Tested at: 426ac0d You can see the results of the tests here: I found follow errors while testing this PR Failed tests: RelVals
When I ran the RelVals I found an error in the following worklfows: runTheMatrix-results/25202.0_TTbar_13+TTbar_13+DIGIUP15_PU25+RECOUP15_PU25+HARVESTUP15_PU25/step2_TTbar_13+TTbar_13+DIGIUP15_PU25+RECOUP15_PU25+HARVESTUP15_PU25.log |
|
Pull request #15055 was updated. @civanch, @Dr15Jones, @ianna, @mdhildreth, @dmitrijus, @cmsbuild, @vanbesien, @davidlange6 can you please check and sign again. |
|
@cmsbuild Please test |
|
The tests are being triggered in jenkins. |
|
@civanch I changed "s" to "solid" and also tried to use namespace wherever needed |
|
-1 Tested at: 87d776d You can see the results of the tests here: I found follow errors while testing this PR Failed tests: RelVals
When I ran the RelVals I found an error in the following worklfows: runTheMatrix-results/50202.0_TTbar_13+TTbar_13+DIGIUP15_PU50+RECOUP15_PU50+HARVESTUP15_PU50/step2_TTbar_13+TTbar_13+DIGIUP15_PU50+RECOUP15_PU50+HARVESTUP15_PU50.log25202.0 step2 runTheMatrix-results/25202.0_TTbar_13+TTbar_13+DIGIUP15_PU25+RECOUP15_PU25+HARVESTUP15_PU25/step2_TTbar_13+TTbar_13+DIGIUP15_PU25+RECOUP15_PU25+HARVESTUP15_PU25.log1003.0 step1 DAS Error |
|
@ianna @civanch @dmitrijus Could you approve this PR at your earliest convenience? |
| z.push_back(*i); ++i; | ||
| LogDebug("SimG4CoreGeometry") << " r=" << *i ; | ||
| LogDebug("SimG4CoreGeometry") << " r=" << *i/cm; |
There was a problem hiding this comment.
@bsunanda - please use namespase
cmsbuild
added
tests-pending
comparison-pending
and removed
comparison-available
tests-approved
labels
|
Pull request #15055 was updated. @civanch, @Dr15Jones, @ianna, @mdhildreth, @dmitrijus, @cmsbuild, @vanbesien, @davidlange6 can you please check and sign again. |
|
@cmsbuild Please test |
|
The tests are being triggered in jenkins. |
|
@ianna @civanch @dmitrijus I have updated PR by adding the namespace in one statement as suggested by Ianna. Could you approve this PR at your earliest convenience? |
|
+1 |
|
Comparison is ready The workflows 140.53, 4.22 have different files in step1_dasquery.log than the ones found in the baseline. You may want to check and retrigger the tests if necessary. You can check it in the "files" directory in the results of the comparisons |
|
+1 |
|
@dmitrijus Please approve this PR |
Also have compatible units in printouts of different DDD objects