DQMServices/Core : gcc 6.0 misleading-indentation warning flags potential bug; with formatting fix ??? #15068
Conversation
|
A new Pull Request was created by @gartung (Patrick Gartung) for CMSSW_8_1_X. It involves the following packages: DQMServices/Core @cmsbuild, @dmitrijus, @vanbesien, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are list here #13028 |
| @@ -205,11 +205,16 @@ DQMNet::unpackQualityData(QReports &qr, uint32_t &flags, const char *from) | |||
| while (*qdata) | |||
| { | |||
| ++nqv; | |||
| while (*qdata) ++qdata; ++qdata; | |||
There was a problem hiding this comment.
This actually makes sense if you look at DQMNet::packQualityData. But I agree, this requires at least a comment.
|
+1 |
cmsbuild
added
dqm-approved
fully-signed
and removed
dqm-pending
pending-signatures
labels
|
The tests are being triggered in jenkins. |
|
This pull request is fully signed and it will be integrated in one of the next CMSSW_8_1_X IBs after it passes the integration tests. This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar |
|
Comparison is ready The workflows 140.53 have different files in step1_dasquery.log than the ones found in the baseline. You may want to check and retrigger the tests if necessary. You can check it in the "files" directory in the results of the comparisons |
I don't know what lines 208-212 of DWMNet.cc are supposed to be doing so I just added line breaks.