TrackingTools/Products fix for bug flagged by gcc 6.0 misleading-indentation warning #15071
Conversation
|
A new Pull Request was created by @gartung (Patrick Gartung) for CMSSW_8_1_X. It involves the following packages: TrackingTools/Producers @cmsbuild, @cvuosalo, @slava77, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are list here #13028 |
|
@cmsbuild please test |
|
The tests are being triggered in jenkins. |
gartung
changed the title
|
@Martin-Grunewald, @perrotta: Could you please OK this change? This bug fix will change the behavior of the StraightLinePropagator that may have been used in the past by HLT. |
|
@cvuosalo : as far as I can see, the hltESPStraightLinePropagator is never used in the current HLT menu. |
|
@jhgoh: Could you please check this PR? This bug fix could change the behavior of the StraightLinePropagator that seems to be used by: RecoMuon/CosmicMuonProducer/python/cosmicMuons_cfi.py |
| @@ -33,7 +33,7 @@ StraightLinePropagatorESProducer::produce(const TrackingComponentsRecord & iReco | |||
|
|
|||
| PropagationDirection dir = alongMomentum; | |||
|
|
|||
| if (pdir == "oppositeToMomentum, alongMomentum, anyDirection") | |||
| // if (pdir == "oppositeToMomentum, alongMomentum, anyDirection") | |||
| if (pdir == "oppositeToMomentum") dir = oppositeToMomentum; | |||
| if (pdir == "alongMomentum") dir = alongMomentum; | |||
| if (pdir == "anyDirection") dir = anyDirection; | |||
There was a problem hiding this comment.
While you're at it, why not add else:
if (pdir == "oppositeToMomentum") dir = oppositeToMomentum;
else if (pdir == "anyDirection") dir = anyDirection;
if for alongMomentum not needed since it's already the default value.
cmsbuild
added
tests-pending
comparison-pending
and removed
comparison-available
tests-approved
labels
|
Pull request #15071 was updated. @cmsbuild, @cvuosalo, @slava77, @davidlange6 can you please check and sign again. |
|
@cmsbuild please test |
|
The tests are being triggered in jenkins. |
|
Comparison is ready The workflows 140.53 have different files in step1_dasquery.log than the ones found in the baseline. You may want to check and retrigger the tests if necessary. You can check it in the "files" directory in the results of the comparisons |
|
@jhgoh: |
|
Piotr Traczyk from the Muon POG approved this change in a separate e-mail thread. Cosmic muons only use the alongMomentum direction, so this change will have no effect for them. |
|
+1 Fixing a bug in the StraightLinePropagatorESProducer. Inspection by experts indicates that the bug fix will not change standard workflows because the code is rarely used and then only in a way insensitive to the bug fix. The code change is satisfactory, and Jenkins tests against baseline CMSSW_8_1_X_2016-07-08-1700 show no significant differences, as expected. |
|
This pull request is fully signed and it will be integrated in one of the next CMSSW_8_1_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar |
cmsbuild
added
reconstruction-approved
fully-signed
and removed
pending-signatures
reconstruction-pending
labels
|
@gartung could you rebase? |
…ent-not-guard-warn TrackingTools/Products fix for bug flagged by gcc 6.0 misleading-indentation warning
The text cannot be equal to the full string and the partial string.