Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SimCalorimetry/EcalTrigPrimProducers fix for bug flagged by gcc 6.0 misleading-indentation warning #15072

Merged
merged 1 commit into from Aug 5, 2016
Merged

SimCalorimetry/EcalTrigPrimProducers fix for bug flagged by gcc 6.0 misleading-indentation warning #15072

merged 1 commit into from Aug 5, 2016

Conversation

gartung
Copy link
Member

@gartung gartung commented Jun 30, 2016 •
edited

Added curly braces as I think author intended.

@cmsbuild cmsbuild added this to the Next CMSSW_8_1_X milestone Jun 30, 2016
@cmsbuild
Copy link
Contributor

A new Pull Request was created by @gartung (Patrick Gartung) for CMSSW_8_1_X.

It involves the following packages:

SimCalorimetry/EcalTrigPrimProducers

@cmsbuild, @rekovic, @mulhearn, @davidlange6 can you please review it and eventually sign? Thanks.
@argiro this is something you requested to watch as well.
@slava77, @Degano, @smuzaffar you are the release manager for this.

cms-bot commands are list here #13028

@gartung
Copy link
Member Author

gartung commented Jul 1, 2016

@cmsbuild please test

@davidlange6
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 19, 2016 •
edited

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/14162/console

@cmsbuild
Copy link
Contributor

-1

Tested at: 2eaf67f

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-15072/14162/summary.html

I found follow errors while testing this PR

Failed tests: RelVals

  • RelVals:

When I ran the RelVals I found an error in the following worklfows:
1003.0 step1

DAS Error

@gartung
Copy link
Member Author

gartung commented Jul 19, 2016

Fails because of missing test data files.

@davidlange6 davidlange6 merged commit 0cb5e3d into cms-sw:CMSSW_8_1_X Aug 5, 2016
@gartung gartung deleted the SimCalorimetry-EcalTrigPrimProducers-fix-indent-not-guard-warn branch August 6, 2016 02:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
comparison-pending l1-pending orp-pending pending-signatures tests-rejected
Projects
None yet
Milestone
Next CMSSW_8_1_X
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@gartung @cmsbuild @davidlange6