Fixed bug that cause Service exceptions to cause aborts #1508
Conversation
If a Service threw an exception during the ending of a processing transition (e.g. end of Event), the exception would cause an abort rather than being propagated as expected. The problem was the Service signal was generated during the destructor of a ‘guard’ class instance. In C++11 those destructors are now implicitly noexcept(true) which caused the abort. The destructor were changed to noexcept(false) and a new method ‘allowThrow()’ was added which is used to avoid throwing an exception while an exception is being propagated out of the function which uses the guard.
|
A new Pull Request was created by @Dr15Jones (Chris Jones) for CMSSW_7_0_X. Fixed bug that cause Service exceptions to cause aborts It involves the following packages: FWCore/Framework @cmsbuild, @Dr15Jones, @ktf, @nclopezo can you please review it and eventually sign? Thanks. |
|
+1 |
|
This pull request is fully signed and it will be integrated in one of the next IBs unless changes or unless it breaks tests. @ktf can you please take care of it? |
|
This pull request is fully signed and it will be integrated in one of the next IBs unless changes or unless it breaks tests. @ktf can you please take care of it? |
…EndEvent Multithreaded framework -- Fixed bug that cause Service exceptions to cause aborts
If a Service threw an exception during the ending of a processing transition (e.g. end of Event), the exception would cause an abort rather than being propagated as expected. The problem was the Service signal was generated during the destructor of a ‘guard’ class instance. In C++11 those destructors are now implicitly noexcept(true) which caused the abort. The destructor were changed to noexcept(false) and a new method ‘allowThrow()’ was added which is used to avoid throwing an exception while an exception is being propagated out of the function which uses the guard.