RecoParticleFlow/PFTracking formatting fix for gcc 6.0 misleading-indentation warning. #15095

gartung · 2016-06-30T21:42:18Z

/home/cms_admin/CMSSW_8_1_X_2016-06-28-1400/src/RecoParticleFlow/PFTracking/src/PFDisplacedVertexHelper.cc: In member function 'bool PFDisplacedVertexHelper::isKaonMass(const reco::PFDisplacedVertex&) const':
/home/cms_admin/CMSSW_8_1_X_2016-06-28-1400/src/RecoParticleFlow/PFTracking/src/PFDisplacedVertexHelper.cc:338:3: warning: this 'if' clause does not guard... [-Wmisleading-indentation]
if (v.trackTypes()[0] == PFDisplacedVertex::T_TO_VERTEX)
^~
/home/cms_admin/CMSSW_8_1_X_2016-06-28-1400/src/RecoParticleFlow/PFTracking/src/PFDisplacedVertexHelper.cc:343:5: note: ...this statement, but the latter is misleadingly indented as if it is guarded by the 'if'
math::XYZVector trkNeutre(trkInit.x()-trkFinal.x(), trkInit.y()-trkFinal.y(),
^~~~

…-indentation warning.

cmsbuild · 2016-06-30T21:42:39Z

A new Pull Request was created by @gartung (Patrick Gartung) for CMSSW_8_1_X.

It involves the following packages:

RecoParticleFlow/PFTracking

@cmsbuild, @cvuosalo, @slava77, @davidlange6 can you please review it and eventually sign? Thanks.
@mmarionncern, @lgray, @rafaellopesdesa, @bachtis, @cbernet this is something you requested to watch as well.
@slava77, @Degano, @smuzaffar you are the release manager for this.

cms-bot commands are list here #13028

gartung · 2016-06-30T21:43:06Z

@Dr15Jones Can you look at this one. Can you use commas like this in C++?

gartung · 2016-06-30T21:43:23Z

RecoParticleFlow/PFTracking/src/PFDisplacedVertexHelper.cc

@@ -332,12 +332,13 @@ int PFDisplacedVertexHelper::lambdaCP(const PFDisplacedVertex& v) const {

 bool PFDisplacedVertexHelper::isKaonMass(const PFDisplacedVertex& v) const {

-  math::XYZVector  trkInit = v.refittedTracks()[1].momentum(), 


slava77 · 2016-07-01T10:22:18Z

@cmsbuild please test

cmsbuild · 2016-07-01T10:22:38Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/13835/console

cmsbuild · 2016-07-01T12:19:44Z

+1
Tested at: a19eff5
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-15095/13835/summary.html

cmsbuild · 2016-07-01T13:02:13Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-15095/13835/summary.html

Dr15Jones · 2016-07-01T13:12:31Z

Insuggest using 4 spaces for intention instead of 2 to match the rest of the file. I suspect that 4 vs 2 was the actual origin of the warning from the compiler.

Dr15Jones · 2016-07-01T13:14:01Z

To answer your question, yes you can us commas like that but it can easily lead to confusion so I usually avoid it.

cmsbuild · 2016-07-11T23:19:19Z

Pull request #15095 was updated. @cmsbuild, @cvuosalo, @slava77, @davidlange6 can you please check and sign again.

cvuosalo · 2016-07-13T21:53:16Z

@cmsbuild please test

cmsbuild · 2016-07-13T21:53:34Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/14047/console

cmsbuild · 2016-07-13T22:03:41Z

-1

Tested at: de578b1

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-15095/14047/summary.html

I found follow errors while testing this PR

Failed tests: RelVals AddOn

RelVals:

When I ran the RelVals I found an error in the following worklfows:
5.1 step1

runTheMatrix-results/5.1_TTbar+TTbarFS+HARVESTFS/step1_TTbar+TTbarFS+HARVESTFS.log

8.0 step1

runTheMatrix-results/8.0_BeamHalo+BeamHalo+DIGICOS+RECOCOS+ALCABH+HARVESTCOS/step1_BeamHalo+BeamHalo+DIGICOS+RECOCOS+ALCABH+HARVESTCOS.log

4.22 step2

runTheMatrix-results/4.22_RunCosmics2011A+RunCosmics2011A+RECOCOSD+ALCACOSD+SKIMCOSD+HARVESTDC/step2_RunCosmics2011A+RunCosmics2011A+RECOCOSD+ALCACOSD+SKIMCOSD+HARVESTDC.log

9.0 step1

runTheMatrix-results/9.0_Higgs200ChargedTaus+Higgs200ChargedTaus+DIGI+RECO+HARVEST/step1_Higgs200ChargedTaus+Higgs200ChargedTaus+DIGI+RECO+HARVEST.log

25.0 step1

runTheMatrix-results/25.0_TTbar+TTbar+DIGI+RECOAlCaCalo+HARVEST+ALCATT/step1_TTbar+TTbar+DIGI+RECOAlCaCalo+HARVEST+ALCATT.log

135.4 step1

runTheMatrix-results/135.4_ZEE_13+ZEEFS_13+HARVESTUP15FS+MINIAODMCUP15FS/step1_ZEE_13+ZEEFS_13+HARVESTUP15FS+MINIAODMCUP15FS.log

1306.0 step1

runTheMatrix-results/1306.0_SingleMuPt1_UP15+SingleMuPt1_UP15+DIGIUP15+RECOUP15+HARVESTUP15/step1_SingleMuPt1_UP15+SingleMuPt1_UP15+DIGIUP15+RECOUP15+HARVESTUP15.log

1330.0 step1

runTheMatrix-results/1330.0_ZMM_13+ZMM_13+DIGIUP15+RECOUP15+HARVESTUP15/step1_ZMM_13+ZMM_13+DIGIUP15+RECOUP15+HARVESTUP15.log

101.0 step1

runTheMatrix-results/101.0_SingleElectronE120EHCAL+SingleElectronE120EHCAL/step1_SingleElectronE120EHCAL+SingleElectronE120EHCAL.log

25202.0 step1

runTheMatrix-results/25202.0_TTbar_13+TTbar_13+DIGIUP15_PU25+RECOUP15_PU25+HARVESTUP15_PU25/step1_TTbar_13+TTbar_13+DIGIUP15_PU25+RECOUP15_PU25+HARVESTUP15_PU25.log

140.53 step2

runTheMatrix-results/140.53_RunHI2011+RunHI2011+RECOHID11+HARVESTDHI/step2_RunHI2011+RunHI2011+RECOHID11+HARVESTDHI.log

50202.0 step1

runTheMatrix-results/50202.0_TTbar_13+TTbar_13+DIGIUP15_PU50+RECOUP15_PU50+HARVESTUP15_PU50/step1_TTbar_13+TTbar_13+DIGIUP15_PU50+RECOUP15_PU50+HARVESTUP15_PU50.log

10021.0 step1

runTheMatrix-results/10021.0_TenMuE_0_200+TenMuE_0_200_pythia8_2017_GenSimFull+DigiFull_2017+RecoFull_2017+HARVESTFull_2017/step1_TenMuE_0_200+TenMuE_0_200_pythia8_2017_GenSimFull+DigiFull_2017+RecoFull_2017+HARVESTFull_2017.log

136.731 step2

runTheMatrix-results/136.731_RunSinglePh2016B+RunSinglePh2016B+HLTDR2_2016+RECODR2_2016reHLT+HARVESTDR2/step2_RunSinglePh2016B+RunSinglePh2016B+HLTDR2_2016+RECODR2_2016reHLT+HARVESTDR2.log

1001.0 step2

runTheMatrix-results/1001.0_RunMinBias2011A+RunMinBias2011A+TIER0EXP+ALCAEXP+ALCAHARVD1+ALCAHARVD2+ALCAHARVD3+ALCAHARVD4+ALCAHARVD5/step2_RunMinBias2011A+RunMinBias2011A+TIER0EXP+ALCAEXP+ALCAHARVD1+ALCAHARVD2+ALCAHARVD3+ALCAHARVD4+ALCAHARVD5.log

1000.0 step2

runTheMatrix-results/1000.0_RunMinBias2011A+RunMinBias2011A+TIER0+SKIMD+HARVESTDfst2+ALCASPLIT/step2_RunMinBias2011A+RunMinBias2011A+TIER0+SKIMD+HARVESTDfst2+ALCASPLIT.log

10024.0 step1

runTheMatrix-results/10024.0_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2017_GenSimFull+DigiFull_2017+RecoFull_2017+HARVESTFull_2017/step1_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2017_GenSimFull+DigiFull_2017+RecoFull_2017+HARVESTFull_2017.log

10624.0 step1

runTheMatrix-results/10624.0_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2023tilted_GenSimFull+DigiFull_2023tilted+RecoFullGlobal_2023tilted+HARVESTFullGlobal_2023tilted/step1_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2023tilted_GenSimFull+DigiFull_2023tilted+RecoFullGlobal_2023tilted+HARVESTFullGlobal_2023tilted.log

1003.0 step2

runTheMatrix-results/1003.0_RunMinBias2012A+RunMinBias2012A+RECODDQM+HARVESTDDQM/step2_RunMinBias2012A+RunMinBias2012A+RECODDQM+HARVESTDDQM.log

11024.0 step1

runTheMatrix-results/11024.0_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2023LReco_GenSimFull+DigiFull_2023LReco+RecoFullLocal_2023LReco/step1_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2023LReco_GenSimFull+DigiFull_2023LReco+RecoFullLocal_2023LReco.log

AddOn:

I found errors in the following addon tests:

cmsDriver.py TTbar_8TeV_TuneCUETP8M1_cfi --conditions auto:run1_mc --fast -n 100 --eventcontent AODSIM,DQM --relval 100000,1000 -s GEN,SIM,RECOBEFMIX,DIGI:pdigi_valid,L1,DIGI2RAW,L1Reco,RECO,EI,HLT:@Fake,VALIDATION --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --datatier GEN-SIM-DIGI-RECO,DQMIO --beamspot Realistic8TeVCollision : FAILED - time: date Thu Jul 14 00:01:34 2016-date Thu Jul 14 00:01:31 2016 s - exit: 256
cmsRun /cvmfs/cms-ib.cern.ch/week1/slc6_amd64_gcc530/cms/cmssw/CMSSW_8_1_X_2016-07-13-1300/src/PhysicsTools/PatAlgos/test/IntegrationTest_cfg.py : FAILED - time: date Thu Jul 14 00:01:38 2016-date Thu Jul 14 00:01:32 2016 s - exit: 16640
cmsDriver.py RelVal -s L1REPACK:Full --data --scenario=pp -n 10 --conditions auto:run2_hlt_PRef --relval 9000,50 --datatier "RAW" --customise=HLTrigger/Configuration/CustomConfigs.L1T --era Run2_2016 --magField 38T_PostLS1 --eventcontent RAW --fileout file:RelVal_Raw_PRef_DATA.root --filein /store/data/Run2016B/JetHT/RAW/v1/000/272/762/00000/C666CDE2-E013-E611-B15A-02163E011DBE.root : FAILED - time: date Thu Jul 14 00:02:12 2016-date Thu Jul 14 00:01:36 2016 s - exit: 16640
cmsRun /cvmfs/cms-ib.cern.ch/week1/slc6_amd64_gcc530/cms/cmssw/CMSSW_8_1_X_2016-07-13-1300/src/HLTrigger/Configuration/test/OnLine_HLT_PRef.py realData=True globalTag=@ inputFiles=@ : FAILED - time: date Thu Jul 14 00:02:12 2016-date Thu Jul 14 00:01:36 2016 s - exit: 16640
cmsDriver.py RelVal -s HLT:PRef,RAW2DIGI,L1Reco,RECO --data --scenario=pp -n 10 --conditions auto:run2_data_PRef --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run2_2016 --magField 38T_PostLS1 --processName=HLTRECO --filein file:RelVal_Raw_PRef_DATA.root --fileout file:RelVal_Raw_PRef_DATA_HLT_RECO.root : FAILED - time: date Thu Jul 14 00:02:12 2016-date Thu Jul 14 00:01:36 2016 s - exit: 16640
cmsDriver.py RelVal -s L1REPACK:Full2015Data --data --scenario=HeavyIons -n 10 --conditions auto:run2_hlt_HIon --relval 9000,50 --datatier "RAW" --eventcontent RAW --customise=HLTrigger/Configuration/CustomConfigs.L1T --era Run2_2016,Run2_HI --magField 38T_PostLS1 --fileout file:RelVal_Raw_HIon_DATA.root --filein /store/hidata/HIRun2015/HIHardProbes/RAW-RECO/HighPtJet-PromptReco-v1/000/263/689/00000/1802CD9A-DDB8-E511-9CF9-02163E0138CA.root : FAILED - time: date Thu Jul 14 00:02:11 2016-date Thu Jul 14 00:01:40 2016 s - exit: 16640
cmsRun /cvmfs/cms-ib.cern.ch/week1/slc6_amd64_gcc530/cms/cmssw/CMSSW_8_1_X_2016-07-13-1300/src/HLTrigger/Configuration/test/OnLine_HLT_HIon.py realData=True globalTag=@ inputFiles=@ : FAILED - time: date Thu Jul 14 00:02:11 2016-date Thu Jul 14 00:01:40 2016 s - exit: 16640
cmsDriver.py RelVal -s HLT:HIon,RAW2DIGI,L1Reco,RECO --data --scenario=HeavyIons -n 10 --conditions auto:run2_data_HIon --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run2_2016,Run2_HI --magField 38T_PostLS1 --processName=HLTRECO --filein file:RelVal_Raw_HIon_DATA.root --fileout file:RelVal_Raw_HIon_DATA_HLT_RECO.root : FAILED - time: date Thu Jul 14 00:02:11 2016-date Thu Jul 14 00:01:40 2016 s - exit: 16640
cmsDriver.py TTbar_Tauola_13TeV_cfi -s GEN,SIM,DIGI,L1,DIGI2RAW --mc --scenario=pp -n 10 --conditions auto:run2_mc_GRun --relval 9000,50 --datatier "GEN-SIM-RAW" --eventcontent RAWSIM --customise=HLTrigger/Configuration/CustomConfigs.L1T --era Run2_2016 --magField 38T_PostLS1 --fileout file:RelVal_Raw_GRun_MC.root : FAILED - time: date Thu Jul 14 00:02:32 2016-date Thu Jul 14 00:01:43 2016 s - exit: 256
cmsRun /cvmfs/cms-ib.cern.ch/week1/slc6_amd64_gcc530/cms/cmssw/CMSSW_8_1_X_2016-07-13-1300/src/HLTrigger/Configuration/test/OnLine_HLT_GRun.py realData=False globalTag=@ inputFiles=@ : FAILED - time: date Thu Jul 14 00:02:32 2016-date Thu Jul 14 00:01:43 2016 s - exit: 16640
cmsDriver.py RelVal -s HLT:GRun,RAW2DIGI,L1Reco,RECO --mc --scenario=pp -n 10 --conditions auto:run2_mc_GRun --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run2_2016 --magField 38T_PostLS1 --processName=HLTRECO --filein file:RelVal_Raw_GRun_MC.root --fileout file:RelVal_Raw_GRun_MC_HLT_RECO.root : FAILED - time: date Thu Jul 14 00:02:32 2016-date Thu Jul 14 00:01:43 2016 s - exit: 16640
cmsDriver.py TTbar_13TeV_TuneCUETP8M1_cfi --conditions auto:run2_mc --fast -n 100 --eventcontent AODSIM,DQM --relval 100000,1000 -s GEN,SIM,RECOBEFMIX,DIGI:pdigi_valid,L1,DIGI2RAW,L1Reco,RECO,EI,HLT:@relval25ns,VALIDATION --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --datatier GEN-SIM-DIGI-RECO,DQMIO --beamspot NominalCollision2015 --era Run2_25ns --magField 38T_PostLS1 : FAILED - time: date Thu Jul 14 00:01:51 2016-date Thu Jul 14 00:01:48 2016 s - exit: 256
cmsDriver.py TTbar_Tauola_13TeV_cfi -s GEN,SIM,DIGI,L1,DIGI2RAW --mc --scenario=pp -n 10 --conditions auto:run2_mc_PRef --relval 9000,50 --datatier "GEN-SIM-RAW" --eventcontent RAWSIM --customise=HLTrigger/Configuration/CustomConfigs.L1T --era Run2_2016 --magField 38T_PostLS1 --fileout file:RelVal_Raw_PRef_MC.root : FAILED - time: date Thu Jul 14 00:02:22 2016-date Thu Jul 14 00:01:51 2016 s - exit: 256
cmsRun /cvmfs/cms-ib.cern.ch/week1/slc6_amd64_gcc530/cms/cmssw/CMSSW_8_1_X_2016-07-13-1300/src/HLTrigger/Configuration/test/OnLine_HLT_PRef.py realData=False globalTag=@ inputFiles=@ : FAILED - time: date Thu Jul 14 00:02:22 2016-date Thu Jul 14 00:01:51 2016 s - exit: 16640
cmsDriver.py RelVal -s HLT:PRef,RAW2DIGI,L1Reco,RECO --mc --scenario=pp -n 10 --conditions auto:run2_mc_PRef --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run2_2016 --magField 38T_PostLS1 --processName=HLTRECO --filein file:RelVal_Raw_PRef_MC.root --fileout file:RelVal_Raw_PRef_MC_HLT_RECO.root : FAILED - time: date Thu Jul 14 00:02:22 2016-date Thu Jul 14 00:01:51 2016 s - exit: 16640
cmsDriver.py TTbar_13TeV_TuneCUETP8M1_cfi --conditions auto:run2_mc --fast -n 100 --eventcontent AODSIM,DQM --relval 100000,1000 -s GEN,SIM,RECOBEFMIX,DIGI:pdigi_valid,L1,DIGI2RAW,L1Reco,RECO,EI,HLT:@relval2016,VALIDATION --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --datatier GEN-SIM-DIGI-RECO,DQMIO --beamspot NominalCollision2015 --era Run2_2016 --magField 38T_PostLS1 : FAILED - time: date Thu Jul 14 00:01:57 2016-date Thu Jul 14 00:01:54 2016 s - exit: 256
cmsDriver.py RelVal -s L1REPACK:Full --data --scenario=pp -n 10 --conditions auto:run2_hlt_PIon --relval 9000,50 --datatier "RAW" --customise=HLTrigger/Configuration/CustomConfigs.L1T --era Run2_2016 --magField 38T_PostLS1 --eventcontent RAW --fileout file:RelVal_Raw_PIon_DATA.root --filein /store/data/Run2016B/JetHT/RAW/v1/000/272/762/00000/C666CDE2-E013-E611-B15A-02163E011DBE.root : FAILED - time: date Thu Jul 14 00:02:37 2016-date Thu Jul 14 00:01:59 2016 s - exit: 16640
cmsRun /cvmfs/cms-ib.cern.ch/week1/slc6_amd64_gcc530/cms/cmssw/CMSSW_8_1_X_2016-07-13-1300/src/HLTrigger/Configuration/test/OnLine_HLT_PIon.py realData=True globalTag=@ inputFiles=@ : FAILED - time: date Thu Jul 14 00:02:37 2016-date Thu Jul 14 00:01:59 2016 s - exit: 16640
cmsDriver.py RelVal -s HLT:PIon,RAW2DIGI,L1Reco,RECO --data --scenario=pp -n 10 --conditions auto:run2_data_PIon --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run2_2016 --magField 38T_PostLS1 --processName=HLTRECO --filein file:RelVal_Raw_PIon_DATA.root --fileout file:RelVal_Raw_PIon_DATA_HLT_RECO.root : FAILED - time: date Thu Jul 14 00:02:37 2016-date Thu Jul 14 00:01:59 2016 s - exit: 16640
cmsDriver.py TTbar_Tauola_8TeV_cfi -s GEN,SIM,DIGI,L1,DIGI2RAW --mc --scenario=pp -n 10 --conditions auto:run1_mc_Fake --relval 9000,50 --datatier "GEN-SIM-RAW" --eventcontent RAWSIM --customise=HLTrigger/Configuration/CustomConfigs.L1T --fileout file:RelVal_Raw_Fake_MC.root : FAILED - time: date Thu Jul 14 00:02:36 2016-date Thu Jul 14 00:02:04 2016 s - exit: 256
cmsRun /cvmfs/cms-ib.cern.ch/week1/slc6_amd64_gcc530/cms/cmssw/CMSSW_8_1_X_2016-07-13-1300/src/HLTrigger/Configuration/test/OnLine_HLT_Fake.py realData=False globalTag=@ inputFiles=@ : FAILED - time: date Thu Jul 14 00:02:36 2016-date Thu Jul 14 00:02:04 2016 s - exit: 16640
cmsDriver.py RelVal -s HLT:Fake,RAW2DIGI,L1Reco,RECO --mc --scenario=pp -n 10 --conditions auto:run1_mc_Fake --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --processName=HLTRECO --filein file:RelVal_Raw_Fake_MC.root --fileout file:RelVal_Raw_Fake_MC_HLT_RECO.root : FAILED - time: date Thu Jul 14 00:02:36 2016-date Thu Jul 14 00:02:04 2016 s - exit: 16640
cmsDriver.py TTbar_Tauola_13TeV_cfi -s GEN,SIM,DIGI,L1,DIGI2RAW --mc --scenario=HeavyIons -n 10 --conditions auto:run2_mc_HIon --relval 9000,50 --datatier "GEN-SIM-RAW" --eventcontent RAWSIM --customise=HLTrigger/Configuration/CustomConfigs.L1T --era Run2_2016,Run2_HI --magField 38T_PostLS1 --fileout file:RelVal_Raw_HIon_MC.root : FAILED - time: date Thu Jul 14 00:02:35 2016-date Thu Jul 14 00:02:08 2016 s - exit: 256
cmsRun /cvmfs/cms-ib.cern.ch/week1/slc6_amd64_gcc530/cms/cmssw/CMSSW_8_1_X_2016-07-13-1300/src/HLTrigger/Configuration/test/OnLine_HLT_HIon.py realData=False globalTag=@ inputFiles=@ : FAILED - time: date Thu Jul 14 00:02:35 2016-date Thu Jul 14 00:02:08 2016 s - exit: 16640
cmsDriver.py RelVal -s HLT:HIon,RAW2DIGI,L1Reco,RECO --mc --scenario=HeavyIons -n 10 --conditions auto:run2_mc_HIon --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run2_2016,Run2_HI --magField 38T_PostLS1 --processName=HLTRECO --filein file:RelVal_Raw_HIon_MC.root --fileout file:RelVal_Raw_HIon_MC_HLT_RECO.root : FAILED - time: date Thu Jul 14 00:02:35 2016-date Thu Jul 14 00:02:08 2016 s - exit: 16640
cmsDriver.py TTbar_Tauola_13TeV_cfi -s GEN,SIM,DIGI,L1,DIGI2RAW --mc --scenario=pp -n 10 --conditions auto:run2_mc_Fake1 --relval 9000,50 --datatier "GEN-SIM-RAW" --eventcontent RAWSIM --customise=HLTrigger/Configuration/CustomConfigs.L1T --era Run2_25ns --fileout file:RelVal_Raw_Fake1_MC.root : FAILED - time: date Thu Jul 14 00:02:42 2016-date Thu Jul 14 00:02:12 2016 s - exit: 256
cmsRun /cvmfs/cms-ib.cern.ch/week1/slc6_amd64_gcc530/cms/cmssw/CMSSW_8_1_X_2016-07-13-1300/src/HLTrigger/Configuration/test/OnLine_HLT_Fake1.py realData=False globalTag=@ inputFiles=@ : FAILED - time: date Thu Jul 14 00:02:42 2016-date Thu Jul 14 00:02:12 2016 s - exit: 16640
cmsDriver.py RelVal -s HLT:Fake1,RAW2DIGI,L1Reco,RECO --mc --scenario=pp -n 10 --conditions auto:run2_mc_Fake1 --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run2_25ns --processName=HLTRECO --filein file:RelVal_Raw_Fake1_MC.root --fileout file:RelVal_Raw_Fake1_MC_HLT_RECO.root : FAILED - time: date Thu Jul 14 00:02:42 2016-date Thu Jul 14 00:02:12 2016 s - exit: 16640
cmsDriver.py RelVal -s L1REPACK:GT1 --data --scenario=pp -n 10 --conditions auto:run1_hlt_Fake --relval 9000,50 --datatier "RAW" --eventcontent RAW --customise=HLTrigger/Configuration/CustomConfigs.L1T --fileout file:RelVal_Raw_Fake_DATA.root --filein /store/data/Run2012A/MuEG/RAW/v1/000/191/718/14932935-E289-E111-830C-5404A6388697.root : FAILED - time: date Thu Jul 14 00:02:56 2016-date Thu Jul 14 00:02:20 2016 s - exit: 16640
cmsRun /cvmfs/cms-ib.cern.ch/week1/slc6_amd64_gcc530/cms/cmssw/CMSSW_8_1_X_2016-07-13-1300/src/HLTrigger/Configuration/test/OnLine_HLT_Fake.py realData=True globalTag=@ inputFiles=@ : FAILED - time: date Thu Jul 14 00:02:56 2016-date Thu Jul 14 00:02:20 2016 s - exit: 16640
cmsDriver.py RelVal -s HLT:Fake,RAW2DIGI,L1Reco,RECO --data --scenario=pp -n 10 --conditions auto:run1_data_Fake --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --processName=HLTRECO --filein file:RelVal_Raw_Fake_DATA.root --fileout file:RelVal_Raw_Fake_DATA_HLT_RECO.root : FAILED - time: date Thu Jul 14 00:02:56 2016-date Thu Jul 14 00:02:20 2016 s - exit: 16640
cmsDriver.py RelVal -s L1REPACK:Full --data --scenario=pp -n 10 --conditions auto:run2_hlt_GRun --relval 9000,50 --datatier "RAW" --eventcontent RAW --customise=HLTrigger/Configuration/CustomConfigs.L1T --era Run2_2016 --magField 38T_PostLS1 --fileout file:RelVal_Raw_GRun_DATA.root --filein /store/data/Run2016B/JetHT/RAW/v1/000/272/762/00000/C666CDE2-E013-E611-B15A-02163E011DBE.root : FAILED - time: date Thu Jul 14 00:03:16 2016-date Thu Jul 14 00:02:22 2016 s - exit: 16640
cmsRun /cvmfs/cms-ib.cern.ch/week1/slc6_amd64_gcc530/cms/cmssw/CMSSW_8_1_X_2016-07-13-1300/src/HLTrigger/Configuration/test/OnLine_HLT_GRun.py realData=True globalTag=@ inputFiles=@ : FAILED - time: date Thu Jul 14 00:03:16 2016-date Thu Jul 14 00:02:22 2016 s - exit: 16640
cmsDriver.py RelVal -s HLT:GRun,RAW2DIGI,L1Reco,RECO --data --scenario=pp -n 10 --conditions auto:run2_data_GRun --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run2_25ns --magField 38T_PostLS1 --processName=HLTRECO --filein file:RelVal_Raw_GRun_DATA.root --fileout file:RelVal_Raw_GRun_DATA_HLT_RECO.root : FAILED - time: date Thu Jul 14 00:03:16 2016-date Thu Jul 14 00:02:22 2016 s - exit: 16640
cmsDriver.py RelVal -s L1REPACK:GCTGT --data --scenario=pp -n 10 --conditions auto:run2_hlt_Fake1 --relval 9000,50 --datatier "RAW" --eventcontent RAW --customise=HLTrigger/Configuration/CustomConfigs.L1T --era Run2_25ns --fileout file:RelVal_Raw_Fake1_DATA.root --filein /store/data/Run2015D/MuonEG/RAW/v1/000/256/677/00000/80950A90-745D-E511-92FD-02163E011C5D.root : FAILED - time: date Thu Jul 14 00:03:12 2016-date Thu Jul 14 00:02:37 2016 s - exit: 16640
cmsRun /cvmfs/cms-ib.cern.ch/week1/slc6_amd64_gcc530/cms/cmssw/CMSSW_8_1_X_2016-07-13-1300/src/HLTrigger/Configuration/test/OnLine_HLT_Fake1.py realData=True globalTag=@ inputFiles=@ : FAILED - time: date Thu Jul 14 00:03:12 2016-date Thu Jul 14 00:02:37 2016 s - exit: 16640
cmsDriver.py RelVal -s HLT:Fake1,RAW2DIGI,L1Reco,RECO --data --scenario=pp -n 10 --conditions auto:run2_data_Fake1 --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run2_25ns --processName=HLTRECO --filein file:RelVal_Raw_Fake1_DATA.root --fileout file:RelVal_Raw_Fake1_DATA_HLT_RECO.root : FAILED - time: date Thu Jul 14 00:03:12 2016-date Thu Jul 14 00:02:37 2016 s - exit: 16640
cmsDriver.py TTbar_Tauola_13TeV_cfi -s GEN,SIM,DIGI,L1,DIGI2RAW --mc --scenario=pp -n 10 --conditions auto:run2_mc_PIon --relval 9000,50 --datatier "GEN-SIM-RAW" --eventcontent RAWSIM --customise=HLTrigger/Configuration/CustomConfigs.L1T --era Run2_2016 --magField 38T_PostLS1 --fileout file:RelVal_Raw_PIon_MC.root : FAILED - time: date Thu Jul 14 00:03:09 2016-date Thu Jul 14 00:02:41 2016 s - exit: 256
cmsRun /cvmfs/cms-ib.cern.ch/week1/slc6_amd64_gcc530/cms/cmssw/CMSSW_8_1_X_2016-07-13-1300/src/HLTrigger/Configuration/test/OnLine_HLT_PIon.py realData=False globalTag=@ inputFiles=@ : FAILED - time: date Thu Jul 14 00:03:09 2016-date Thu Jul 14 00:02:41 2016 s - exit: 16640
cmsDriver.py RelVal -s HLT:PIon,RAW2DIGI,L1Reco,RECO --mc --scenario=pp -n 10 --conditions auto:run2_mc_PIon --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run2_2016 --magField 38T_PostLS1 --processName=HLTRECO --filein file:RelVal_Raw_PIon_MC.root --fileout file:RelVal_Raw_PIon_MC_HLT_RECO.root : FAILED - time: date Thu Jul 14 00:03:09 2016-date Thu Jul 14 00:02:41 2016 s - exit: 16640

cvuosalo · 2016-07-14T16:58:39Z

@cmsbuild please test

cmsbuild · 2016-07-14T16:59:01Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/14074/console

gartung · 2016-07-14T17:09:50Z

Test failures are because files needed for test are missing.

cmsbuild · 2016-07-14T18:23:27Z

+1
Tested at: de578b1
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-15095/14074/summary.html

cmsbuild · 2016-07-14T19:28:39Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-15095/14074/summary.html

cvuosalo · 2016-07-14T20:12:30Z

+1

For #15095 de578b1

Cleaning up PFDisplacedVertexHelper code to enhance readability. There should be no change in compiler output.

The code changes are satisfactory, and Jenkins tests against baseline CMSSW_8_1_X_2016-07-14-1100 show no significant differences, as expected.

cmsbuild · 2016-07-14T20:12:53Z

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_1_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @smuzaffar

RecoParticleFlow/PFTracking fix for bug flagged by gcc 6.0 misleading…

a19eff5

…-indentation warning.

cmsbuild added this to the Next CMSSW_8_1_X milestone Jun 30, 2016

cmsbuild added reconstruction-pending pending-signatures tests-pending orp-pending comparison-pending labels Jun 30, 2016

gartung reviewed Jun 30, 2016
View reviewed changes

cmsbuild added tests-started and removed tests-pending labels Jul 1, 2016

cmsbuild added tests-approved and removed tests-started labels Jul 1, 2016

cmsbuild added comparison-available and removed comparison-pending labels Jul 1, 2016

Just make this a formatting fix.

5257b19

cmsbuild added fully-signed tests-pending and removed comparison-available pending-signatures reconstruction-pending tests-approved labels Jul 1, 2016

cmsbuild added the comparison-pending label Jul 11, 2016

cmsbuild added tests-started and removed tests-pending labels Jul 13, 2016

cmsbuild added tests-rejected and removed tests-started labels Jul 13, 2016

cmsbuild added tests-pending and removed tests-rejected labels Jul 14, 2016

cmsbuild added tests-started and removed tests-pending labels Jul 14, 2016

cmsbuild added tests-approved and removed tests-started labels Jul 14, 2016

cmsbuild added comparison-available and removed comparison-pending labels Jul 14, 2016

cmsbuild added reconstruction-approved fully-signed and removed pending-signatures reconstruction-pending labels Jul 14, 2016

davidlange6 merged commit b2cec8f into cms-sw:CMSSW_8_1_X Jul 15, 2016

gartung deleted the RecoParticleFlow-PFTracking-client-fix-indent-not-guard-warn branch July 20, 2016 14:13

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

RecoParticleFlow/PFTracking formatting fix for gcc 6.0 misleading-indentation warning. #15095

RecoParticleFlow/PFTracking formatting fix for gcc 6.0 misleading-indentation warning. #15095

gartung commented Jun 30, 2016

cmsbuild commented Jun 30, 2016

gartung commented Jun 30, 2016

gartung Jun 30, 2016

slava77 commented Jul 1, 2016

cmsbuild commented Jul 1, 2016 •

edited

cmsbuild commented Jul 1, 2016

cmsbuild commented Jul 1, 2016

Dr15Jones commented Jul 1, 2016

Dr15Jones commented Jul 1, 2016

cmsbuild commented Jul 11, 2016

cvuosalo commented Jul 13, 2016

cmsbuild commented Jul 13, 2016 •

edited

cmsbuild commented Jul 13, 2016

cvuosalo commented Jul 14, 2016

cmsbuild commented Jul 14, 2016 •

edited

gartung commented Jul 14, 2016

cmsbuild commented Jul 14, 2016

cmsbuild commented Jul 14, 2016

cvuosalo commented Jul 14, 2016

cmsbuild commented Jul 14, 2016

		@@ -332,12 +332,13 @@ int PFDisplacedVertexHelper::lambdaCP(const PFDisplacedVertex& v) const {

		bool PFDisplacedVertexHelper::isKaonMass(const PFDisplacedVertex& v) const {

		math::XYZVector trkInit = v.refittedTracks()[1].momentum(),

RecoParticleFlow/PFTracking formatting fix for gcc 6.0 misleading-indentation warning. #15095

RecoParticleFlow/PFTracking formatting fix for gcc 6.0 misleading-indentation warning. #15095

Conversation

gartung commented Jun 30, 2016

cmsbuild commented Jun 30, 2016

gartung commented Jun 30, 2016

gartung Jun 30, 2016

Choose a reason for hiding this comment

slava77 commented Jul 1, 2016

cmsbuild commented Jul 1, 2016 • edited

cmsbuild commented Jul 1, 2016

cmsbuild commented Jul 1, 2016

Dr15Jones commented Jul 1, 2016

Dr15Jones commented Jul 1, 2016

cmsbuild commented Jul 11, 2016

cvuosalo commented Jul 13, 2016

cmsbuild commented Jul 13, 2016 • edited

cmsbuild commented Jul 13, 2016

cvuosalo commented Jul 14, 2016

cmsbuild commented Jul 14, 2016 • edited

gartung commented Jul 14, 2016

cmsbuild commented Jul 14, 2016

cmsbuild commented Jul 14, 2016

cvuosalo commented Jul 14, 2016

cmsbuild commented Jul 14, 2016

cmsbuild commented Jul 1, 2016 •

edited

cmsbuild commented Jul 13, 2016 •

edited

cmsbuild commented Jul 14, 2016 •

edited