new ParticleGun-RandomtXiGunProducer for CTPPS #15096
Conversation
|
A new Pull Request was created by @sandrofonseca (Sandro Fonseca de Souza) for CMSSW_8_1_X. It involves the following packages: Configuration/Generator @covarell, @perrozzi, @thuer, @cmsbuild, @davidlange6, @govoni can you please review it and eventually sign? Thanks. cms-bot commands are list here #13028 |
|
@sandrofonseca: any follow up on this? is it still relevant? |
|
please test |
|
The tests are being triggered in jenkins. |
|
@sandrofonseca in the meanwhile I trigger the tests, we will finish reviewing the PR int he meanwhile |
|
+1 |
|
This pull request is fully signed and it will be integrated in one of the next CMSSW_8_1_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @smuzaffar |
cmsbuild
added
generators-approved
fully-signed
and removed
generators-pending
pending-signatures
labels
|
Dear Experts, |
|
+1 |
|
This no longer compiles because of #15897 |
| // to keep the EventContent definitions happy | ||
| // later on we might put the info into the run info that this is a PGun | ||
| auto_ptr<GenRunInfoProduct> genRunInfo( new GenRunInfoProduct() ); | ||
| run.put( genRunInfo ); |
There was a problem hiding this comment.
These two lines won't compile anymore. They need to be changed to
run.put( std::make_unique<GenRunInfoProduct>() );
As suggested by @Dr15Jones here #15096 (comment)
@covarell @govoni
Hi Roberto and Pietro
We are opening a PR for RandomtXiProducer which was used in the publication of the CTPPS TDR.
Below, you can find some cmsDriver commands as one example to use it.
cmsDriver.py SingleProton_RandomtXiGunProducer_cfi.py --mc --eventcontent FEVTDEBUG --datatier GEN-SIM --conditions 80X_mcRun2_asymptotic_2016_v2 --step GEN,SIM --era Run2_25ns --processName=CTPPS -n 2 --no_exec
Let us know your opnion about this PR
Thanks in advance,
Sandro