New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add option to switch off time calibration 81x #15113
Conversation
A new Pull Request was created by @argiro for CMSSW_8_1_X. It involves the following packages: RecoLocalCalo/EcalRecProducers @cmsbuild, @cvuosalo, @slava77, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are list here #13028 |
@cmsbuild please test |
The tests are being triggered in jenkins. |
Comparison is ready The workflows 1003.0, 1001.0, 1000.0 have different files in step1_dasquery.log than the ones found in the baseline. You may want to check and retrigger the tests if necessary. You can check it in the "files" directory in the results of the comparisons |
+1 Adding the option to the ECAL rec hit producer to switch off time calibration. The option defaults to false, so there is no change in the behavior of standard workflows. There should be no change in monitored quantities. #15112 is the 80X version of this PR, and it has already been approved. The code changes are satisfactory, and Jenkins tests against baseline CMSSW_8_1_X_2016-07-05-1100 show no significant differences, as expected. |
This pull request is fully signed and it will be integrated in one of the next CMSSW_8_1_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar |
this will be useful at HLT where no timing is ran to save time and avoid confusing results