Implementing pixel cluster trend plots #15121
Conversation
|
A new Pull Request was created by @leggat for CMSSW_8_1_X. It involves the following packages: DQM/SiPixelMonitorCluster @cmsbuild, @dmitrijus, @vanbesien, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are list here #13028 |
|
@cmsbuild , please test |
|
The tests are being triggered in jenkins. |
|
Comparison is ready The workflows 1003.0, 1001.0, 1000.0 have different files in step1_dasquery.log than the ones found in the baseline. You may want to check and retrigger the tests if necessary. You can check it in the "files" directory in the results of the comparisons |
| }else{ | ||
| if (!(DBdisk > disksmz.size()) && (disksmz[DBdisk-1])) disksmz[DBdisk-1]->Fill(clustgp.x(),clustgp.y()); | ||
| if (!(DBdisk > disksmz.size()) && (disksmz[DBdisk-1])) disksmz[DBdisk-1]->Fill(clustgp.x(),clustgp.y()); |
There was a problem hiding this comment.
I like this change, the entire purpose of it.
|
+1 |
cmsbuild
added
dqm-approved
fully-signed
and removed
dqm-pending
pending-signatures
labels
|
This pull request is fully signed and it will be integrated in one of the next CMSSW_8_1_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar |
|
80x ref: #15120 |
Lumisection based cluster trend plots for the barrel and endcap of the pixel detector DQM