Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Compilation Errors with EDM_ML_DEBUG Defined #15128

Merged
merged 1 commit into from Jul 11, 2016

Conversation

ianna
Copy link
Contributor

@ianna ianna commented Jul 6, 2016

  • Allow compilation with EDM_ML_DEBUG
  • Silence non-debug printout

@bsunanda - FYI, when you need debug output from DDHCalEndcapAlgo, just check it out and build it with:

scram b USER_CXXFLAGS="-DEDM_ML_DEBUG"

* Silence non-debug printout
@ianna
Copy link
Contributor Author

ianna commented Jul 6, 2016

please test

@cmsbuild cmsbuild added this to the Next CMSSW_8_1_X milestone Jul 6, 2016
@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 6, 2016

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/13897/console

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 6, 2016

A new Pull Request was created by @ianna (Ianna Osborne) for CMSSW_8_1_X.

It involves the following packages:

DataFormats/EcalDetId
DetectorDescription/ExprAlgo
Geometry/HcalAlgo
Geometry/TrackerGeometryBuilder

@civanch, @Dr15Jones, @ianna, @mdhildreth, @cmsbuild, @davidlange6 can you please review it and eventually sign? Thanks.
@ghellwig, @makortel, @VinInn, @argiro, @venturia this is something you requested to watch as well.
@slava77, @Degano, @smuzaffar you are the release manager for this.

cms-bot commands are list here #13028

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 6, 2016

-1

Tested at: dda5cf3

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-15128/13897/summary.html

I found follow errors while testing this PR

Failed tests: RelVals

  • RelVals:

When I ran the RelVals I found an error in the following worklfows:
1000.0 step1

DAS Error
1001.0 step1
DAS Error

@ianna
Copy link
Contributor Author

ianna commented Jul 7, 2016

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 7, 2016

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/13924/console

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 7, 2016

@ianna
Copy link
Contributor Author

ianna commented Jul 7, 2016

+1

@ianna
Copy link
Contributor Author

ianna commented Jul 7, 2016

@davidlange6 - please, take this PR at your earliest convenience. Relvals do not run tests with EDM_ML_DEBUG enabled. However, we need to be sure debugging is possible and encourage a standard way of doing it.

@Dr15Jones and @smuzaffar FYI.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 7, 2016

@davidlange6 davidlange6 merged commit 821338b into cms-sw:CMSSW_8_1_X Jul 11, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants