Changing quotes of AlCa matrix to be JSON valid #15139
Conversation
|
A new Pull Request was created by @jonuuukas for CMSSW_8_1_X. It involves the following packages: Configuration/AlCa @ghellwig, @cerminar, @cmsbuild, @franzoni, @mmusich, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are list here #13028 |
|
please test |
|
The tests are being triggered in jenkins. |
| "SingleMu" : "MuAlCalIsolatedMu+MuAlOverlaps+TkAlMuonIsolated+DtCalib+MuAlZMuMu+HcalCalHO", | ||
| "SingleMuon" : "TkAlMuonIsolated+DtCalib+MuAlCalIsolatedMu+MuAlOverlaps+MuAlZMuMu+HcalCalIterativePhiSym", | ||
| "SinglePhoton" : "HcalCalGammaJet", | ||
| "ZeroBias" : "SiStripCalZeroBias+TkAlMinBias+LumiPixelsMinBias+SiStripCalMinBias", |
There was a problem hiding this comment.
@jonuuukas from the title of the PR I would expect that you change only from single to double quotes, but here you are removing '+EcalTrg'. Is that intended?
There was a problem hiding this comment.
that is not intended, sorry. fixing ASAP
|
-1 |
cmsbuild
added
alca-pending
tests-pending
and removed
alca-rejected
tests-started
labels
|
please test |
|
The tests are being triggered in jenkins. |
|
+1 |
|
This pull request is fully signed and it will be integrated in one of the next CMSSW_8_1_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar |
cmsbuild
added
alca-approved
fully-signed
and removed
alca-pending
pending-signatures
labels
|
@jonuuukas can you elaborate what is the rationale behind the proposed changes? Is it for usage within CMSSW? |
|
JSON valid configurations are needed for the data management app I'm currently developing. As single quotes are not supported, @anorkus suggested to change this file |
changed the matrix dict attributes from single qoutes to double quotes to be JSON valid