Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updating JECs and Tracker Alignment tag for HLT #15174

Merged

Conversation

mmusich
Copy link
Contributor

@mmusich mmusich commented Jul 12, 2016

Summary of changes in Global Tags

RunII simulation

RunII data

Side note: the change of snapshot will allow to "see" in the data (HLT and RECO) Global Tags the new IOV for 2016B as in the ICHEP Re-Reco @fabozzi

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @mmusich (Marco Musich) for CMSSW_8_0_X.

It involves the following packages:

Configuration/AlCa

@ghellwig, @cerminar, @cmsbuild, @franzoni, @mmusich, @davidlange6 can you please review it and eventually sign? Thanks.
@makortel, @Martin-Grunewald, @ghellwig, @tocheng this is something you requested to watch as well.
@slava77, @Degano, @smuzaffar you are the release manager for this.

cms-bot commands are list here #13028

@mmusich
Copy link
Contributor Author

mmusich commented Jul 12, 2016

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 12, 2016

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/13992/console

@cmsbuild
Copy link
Contributor

-1

Tested at: e15fbec

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-15174/13992/summary.html

I found follow errors while testing this PR

Failed tests: UnitTests RelVals AddOn

  • Unit Tests:

I found errors in the following unit tests:

---> test runtestPhysicsToolsPatAlgos had ERRORS

  • RelVals:

When I ran the RelVals I found an error in the following worklfows:
25202.0 step2

runTheMatrix-results/25202.0_TTbar_13+TTbar_13+DIGIUP15_PU25+RECOUP15_PU25+HARVESTUP15_PU25/step2_TTbar_13+TTbar_13+DIGIUP15_PU25+RECOUP15_PU25+HARVESTUP15_PU25.log
50202.0 step2
runTheMatrix-results/50202.0_TTbar_13+TTbar_13+DIGIUP15_PU50+RECOUP15_PU50+HARVESTUP15_PU50/step2_TTbar_13+TTbar_13+DIGIUP15_PU50+RECOUP15_PU50+HARVESTUP15_PU50.log
4.22 step1
DAS Error
1000.0 step1
DAS Error
1001.0 step1
DAS Error
  • AddOn:

I found errors in the following addon tests:

cmsRun /build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_8_0_X_2016-07-10-0000/src/PhysicsTools/PatAlgos/test/IntegrationTest_cfg.py : FAILED - time: date Tue Jul 12 17:37:49 2016-date Tue Jul 12 17:37:04 2016 s - exit: 23552

@mmusich
Copy link
Contributor Author

mmusich commented Jul 12, 2016

nice...

@mmusich
Copy link
Contributor Author

mmusich commented Jul 13, 2016

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 13, 2016

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/14005/console

@cmsbuild
Copy link
Contributor

-1

Tested at: e15fbec

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-15174/14005/summary.html

I found follow errors while testing this PR

Failed tests: UnitTests RelVals

  • Unit Tests:

I found errors in the following unit tests:

---> test runtestPhysicsToolsPatAlgos had ERRORS

  • RelVals:

When I ran the RelVals I found an error in the following worklfows:
1000.0 step1

DAS Error
1001.0 step1
DAS Error

@mmusich
Copy link
Contributor Author

mmusich commented Jul 13, 2016

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 13, 2016

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/14012/console

@mmusich
Copy link
Contributor Author

mmusich commented Jul 18, 2016

@cmsbuild please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 18, 2016

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/14122/console

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@mmusich
Copy link
Contributor Author

mmusich commented Jul 18, 2016

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_0_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @smuzaffar

@mmusich
Copy link
Contributor Author

mmusich commented Jul 19, 2016

@davidlange6 just to clarify the apparent change in the run2 MC GTs, it should not change the physics performance, since in the new payloads (V3 vs V1) a new level of correction (not consumed) is added, while keeping the rest the same. Please refer to this thread HN link @blinkseb FYI.

@davidlange6
Copy link
Contributor

@mmusich - when discussed yesterday this PR affected only data - however it looks like MC GTs are also updated. Are these already in use for production?

@mmusich
Copy link
Contributor Author

mmusich commented Jul 20, 2016

Hi @davidlange6,
see please my comment #15174 (comment).
The change is somewhat only technical being the content of the level of the Jet corrections consumed at miniAOD the same. I think the JETMET group changed the nomenclature mostly to keep the same version number of the data ones (see here: https://hypernews.cern.ch/HyperNews/CMS/get/calibrations/2417/1/1/1.html).
On a side note, this has already been validated in 81x.

@davidlange6
Copy link
Contributor

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants