Delete memory from TUnixSystem::ExpandPathName call #15181
Conversation
The pointer returned from TUnixSystem::ExpandPathName must be deleted by the caller.
|
A new Pull Request was created by @Dr15Jones (Chris Jones) for CMSSW_8_1_X. It involves the following packages: IOPool/Input @cmsbuild, @smuzaffar, @Dr15Jones, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are list here #13028 |
|
please test |
|
+1 |
cmsbuild
added
core-approved
fully-signed
and removed
core-pending
pending-signatures
labels
|
The tests are being triggered in jenkins. |
|
This pull request is fully signed and it will be integrated in one of the next CMSSW_8_1_X IBs after it passes the integration tests. This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar |
|
-1 Tested at: d93e11e The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: You can see the results of the tests here: I found follow errors while testing this PR Failed tests: RelVals AddOn
When I ran the RelVals I found an error in the following worklfows: DAS Error1000.0 step1 DAS Error1001.0 step1 DAS Error
I found errors in the following addon tests: cmsRun /cvmfs/cms-ib.cern.ch/week1/slc6_amd64_gcc530/cms/cmssw-patch/CMSSW_8_1_X_2016-07-12-1600/src/PhysicsTools/PatAlgos/test/IntegrationTest_cfg.py : FAILED - time: date Wed Jul 13 02:39:35 2016-date Wed Jul 13 02:38:48 2016 s - exit: 23552 The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: |
|
+1 |
|
please test |
|
The tests are being triggered in jenkins. |
The pointer returned from TUnixSystem::ExpandPathName must be deleted by the caller. This was caught by valgrind and then the ROOT documentation explicitly says to delete the return value.