Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review occupancy test #15209

Merged
merged 3 commits into from Aug 18, 2016
Merged

Conversation

fcavallo
Copy link
Contributor

No description provided.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @fcavallo (Francesca Romana Cavallo) for CMSSW_8_0_X.

It involves the following packages:

DQM/DTMonitorClient

@cmsbuild, @dmitrijus, @vanbesien, @davidlange6 can you please review it and eventually sign? Thanks.
@slava77, @smuzaffar you are the release manager for this.

cms-bot commands are list here #13028

@dmitrijus
Copy link
Contributor

+1
Code looks fine, but in order for this to be merged, you need a better title/description of this PR, and a link to 81x version if it (nothing in 80x is merged before 81x).

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 19, 2016

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/14165/console

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_0_X IBs after it passes the integration tests. This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @smuzaffar

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@davidlange6
Copy link
Contributor

@fcavallo @dmitrijus - what is the 81x version of this?

@fcavallo
Copy link
Contributor Author

fcavallo commented Aug 1, 2016

Hi. sorry I kind of lost the thread. So am I supposed to make the same PR in 81x before having this one merged?

@davidlange6
Copy link
Contributor

Hi @fcavallo - yes (as always, we test in the development release first)

@davidlange6
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit ab09231 into cms-sw:CMSSW_8_0_X Aug 18, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants