dqm plot, pixel endcap roc occupancy in 81x #15237
Conversation
|
A new Pull Request was created by @gouskos for CMSSW_8_1_X. It involves the following packages: DQM/SiPixelMonitorTrack @cmsbuild, @dmitrijus, @vanbesien, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are list here #13028 |
|
hello @dmitrijus , could you please trigger the tests ? Thanks |
|
+1 |
cmsbuild
added
dqm-approved
fully-signed
and removed
dqm-pending
pending-signatures
labels
|
The tests are being triggered in jenkins. |
|
This pull request is fully signed and it will be integrated in one of the next CMSSW_8_1_X IBs after it passes the integration tests. This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @smuzaffar |
| } | ||
| if (pxfblade>0) { clu_roc_biny = clu_roc_biny+144; } | ||
|
|
||
| meRocBladevsDiskEndcap->setBinContent(clu_roc_binx,clu_roc_biny, meRocBladevsDiskEndcap->getBinContent(clu_roc_binx,clu_roc_biny)+1); |
There was a problem hiding this comment.
@gouskos - is this not the same as meRocBladevsDiskEndcap->Fill(....)?
There was a problem hiding this comment.
@gouskos - to answer my question, "no" - but the appropriate function call is meRocBladevsDiskEndcap->AddBinContent(clu_roc_binx,clu_roc_biny)
could you have a look. Thanks
There was a problem hiding this comment.
Hi, there is no function "AddBinContent" for the MonitorElement class.
There was a problem hiding this comment.
@gouskos if you use the correct function from here http://cmslxr.fnal.gov/source/DQMServices/Core/interface/MonitorElement.h#0337 you can get the root object (TH2) and use the AddBinContent function on it. Hope this helps.
|
Ok - I will update the code asap |
|
@davidlange6 , @dmitrijus I tried following your suggestion by implementing the code below: Int_t bin = meRocBladevsDiskEndcap->getTH2F()->GetBin(clu_roc_binx,clu_roc_biny); However the histograms are not filled. I spent some time debugging this but without success. Given that this PR is quite urgent for the tracker, you it be possible to consider staying with the initial version of the code and then try to improve the code with your suggestions? The same holds also for the 80X version of this PR [15236] |
|
@davidlange6 and @dmitrijus I confirm what @gouskos said, we had a try to implement the changes suggested by David but it doesn't seem to work properly. If you think that what we did is wrong please give a suggestion on what should be changed. However this PR is quite urgent to have merged, it will allow to build a monitor of inefficienct ROCS in Pixels. I would like this to be merged and we can continue searching for a more efficient way to do the same thing. |
|
+1 weird - maybe a bug in root - will try to test |
No description provided.