Enable pixel inefficiency for Phase I

[jkarancs]

This PR enables the use of new Phase I Pixel failure/inefficiency scenarios.

Content of the PR:

• Enable pixel inefficiency simulation for the Phase I detector
• Remove deprecated configuration settings in the era file, corresponding to 25/50ns operation
• modifyPixelDigitizerForPhase1PixelWithPileup function no longer needed, a similar/same DB content can be provided to replace it

By default the current content in the database have inefficiencies of 0.999, therefore the effect of this change is minimal.

[cmsbuild]

A new Pull Request was created by @jkarancs (János Karancsi) for CMSSW_8_1_X.

It involves the following packages:

SimGeneral/MixingModule

@cmsbuild, @civanch, @mdhildreth, @davidlange6 can you please review it and eventually sign? Thanks.
@wmtan this is something you requested to watch as well.
@slava77, @smuzaffar you are the release manager for this.

cms-bot commands are list here #13028

[civanch]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/14182/console

[cmsbuild]

+1
Tested at: eab92ee
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-15238/14182/summary.html

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-15238/14182/summary.html

[civanch]

@jkarancs , there are a lot of differences for 10021 10024 Phase1 workflows. Are they expected?

[jkarancs]

Yes, but only very small changes are expected at the per mil level, because the db payload contains 99.9% efficiencies instead of the off settings, which is effectively 100%. Do you see any large changes?

[civanch]

@jkarancs , for example, please, have a look https://cmssdt.cern.ch/SDT/jenkins-artifacts/baseLineComparisons/CMSSW_8_1_X_2016-07-19-1100+15238/15024/10024.0_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2017_GenSimFull+DigiFull_2017+RecoFull_2017+HARVESTFull_2017/
can all these difference be qualified as changed simulation history due to 0.99 efficiency?

[jkarancs]

@civanch, it's hard to determine without seeing any concrete example of a failed comparison. But since the GlobalTag content has 99.9% efficiency that roughly means every 1000th cluster is lost, this indeed can cause the failure of some comparisons as long as the threshold for allowed changes is very low. eg. if a loss of a particle can cause the failure of a comparison, I think this is acceptable.

[civanch]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_1_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @smuzaffar

[davidlange6]

@jkarancs @civanch - so the conclusion is that the changes observed are expected? (contrary to the description of the PR) - if so, could you please update the PR description to reflect this new understanding. Thanks

[jkarancs]

@davidlange6 , yes, very small changes are acceptable, because we go from effectively 100.0% to 99.9% efficiencies. I updated the PR description.

[davidlange6]

+1
thanks