Extended o2o for81x

[kkotov]

Updated version of the extendedO2O branch

[cmsbuild]

A new Pull Request was created by @kkotov for CMSSW_8_1_X.

It involves the following packages:

CondCore/L1TPlugins
CondFormats/DataRecord
CondFormats/L1TObjects
CondTools/L1Trigger
CondTools/L1TriggerExt
L1Trigger/L1TCommon
L1TriggerConfig/L1TUtmTriggerMenuProducers

@ghellwig, @cerminar, @cmsbuild, @rekovic, @franzoni, @ggovi, @mmusich, @mulhearn, @davidlange6 can you please review it and eventually sign? Thanks.
@ghellwig, @Martin-Grunewald, @apfeiffer1, @tocheng this is something you requested to watch as well.
@slava77, @smuzaffar you are the release manager for this.

cms-bot commands are list here #13028

[mmusich]

@kkotov this branch appears to have conflicts to be resolved. You might consider to rebase it.
Thanks

[kkotov]

please test

[cmsbuild]

Pull request #15243 was updated. @ghellwig, @cerminar, @cmsbuild, @rekovic, @franzoni, @ggovi, @mmusich, @mulhearn, @davidlange6 can you please check and sign again.

[kkotov]

@mmusich , thanks for pointing out. just rebased ...

[mmusich]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/14189/console

[cmsbuild]

+1
Tested at: edda649
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-15243/14189/summary.html

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
edda649
6b27034
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-15243/14189/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-15243/14189/git-merge-result

[kkotov]

@davidlange6 @mmusich , done capitalizing class names. All guards were in place. We also decided to keep the naming scheme.

[cmsbuild]

Pull request #15243 was updated. @ghellwig, @cerminar, @cmsbuild, @rekovic, @franzoni, @ggovi, @mmusich, @mulhearn, @davidlange6 can you please check and sign again.

[mmusich]

thanks @kkotov

[mmusich]

I am not sure if triggering the tests is meaningful because of the DAS failures in the bot tests in other PRs.

[mmusich]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/14361/console

[cmsbuild]

-1

Tested at: aec6c08

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-15243/14361/summary.html

I found follow errors while testing this PR

Failed tests: RelVals

• RelVals:

When I ran the RelVals I found an error in the following worklfows:
140.53 step1

DAS Error

[mmusich]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/14415/console

[cmsbuild]

+1
Tested at: aec6c08
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-15243/14415/summary.html

[mmusich]

+1

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-15243/14415/summary.html

[davidlange6]

@kkotov - thanks
for a followup PR please change the include guards for classes like Mask and Settings to include the subsystem and package name (as normal convention for CMSSW).