Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LHE Reader Cleanup #15246

Merged
merged 1 commit into from Jul 21, 2016
Merged

LHE Reader Cleanup #15246

merged 1 commit into from Jul 21, 2016

Conversation

ianna
Copy link
Contributor

@ianna ianna commented Jul 21, 2016

  • Release resources in Xerces validity scope

Note: a quick fix to avoid access to Xerces after it has been finalized. More thorough refactoring of the code is needed to allow proper use of it.

@Dr15Jones, @smuzaffar, @davidlange6 - FYI, it should fix IB validation workflows (the tests are still running).

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @ianna (Ianna Osborne) for CMSSW_8_1_X.

It involves the following packages:

GeneratorInterface/LHEInterface

@covarell, @perrozzi, @thuer, @cmsbuild, @davidlange6, @govoni can you please review it and eventually sign? Thanks.
@agrohsje, @mkirsano this is something you requested to watch as well.
@slava77, @smuzaffar you are the release manager for this.

cms-bot commands are list here #13028

@ianna
Copy link
Contributor Author

ianna commented Jul 21, 2016

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 21, 2016

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/14194/console

@ianna
Copy link
Contributor Author

ianna commented Jul 21, 2016

@davidlange6 and @smuzaffar - workflow 512.0 runs fine locally

@davidlange6
Copy link
Contributor

since the workflows are broken, I am merging while the tests are in progress.

@davidlange6 davidlange6 merged commit 770d8e7 into cms-sw:CMSSW_8_1_X Jul 21, 2016
@ianna
Copy link
Contributor Author

ianna commented Jul 21, 2016

@davidlange6 and @smuzaffar - I assume the rest of the workflows should be fine as well:

512.0_DYTollJets_LO_Mad_13TeV_py8+DYToll01234Jets_5f_LO_MLM_Madgraph_LHE_13TeV+Hadronizer_TuneCUETP8M1_13TeV_MLM_5f_max4j_LHE_pythia8+HARVESTGEN2 Step0-PASSED Step1-PASSED Step2-PASSED  - time date Thu Jul 21 10:13:35 2016-date Thu Jul 21 09:58:34 2016; exit: 0 0 0
1 1 1 tests passed, 0 0 0 failed

1360.0_TTbar012Jets_NLO_Mad_py8_Evt_13+TTbar012Jets_NLO_Mad_py8_Evt_13+DIGIUP15+RECOUP15+HARVESTUP15 Step0-PASSED Step1-PASSED Step2-PASSED Step3-PASSED  - time date Thu Jul 21 10:40:11 2016-date Thu Jul 21 10:16:45 2016; exit: 0 0 0 0
1 1 1 1 tests passed, 0 0 0 0 failed

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@smuzaffar
Copy link
Contributor

IB looks good after these changes

@smuzaffar
Copy link
Contributor

testing comment's timezone (please ignore)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants