Fixed bug that cause Service exceptions to cause aborts #1526
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a Service threw an exception during the ending of a processing transition (e.g. end of Event), the exception would cause an abort rather than being propagated as expected. The problem was the Service signal was generated during the destructor of a 'guard' class instance. In C++11 those destructors are now implicitly noexcept(true) which caused the abort. The destructor were changed to noexcept(false) and a new method 'allowThrow()' was added which is used to avoid throwing an exception while an exception is being propagated out of the function which uses the guard. This fix was already introduced to CMSSW_7_0_X but given the large changes between the two releases this had to be reimplemented by hand.
|
+1 |
|
This pull request is fully signed and it will be integrated in one of the next IBs unless changes or unless it breaks tests. @davidlt can you please take care of it? |
|
+1 |
ghost
assigned
davidlt
added a commit
that referenced
this pull request
Nov 24, 2013
…EndEventFor6_2_X Fixed bug that cause Service exceptions to cause aborts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a Service threw an exception during the ending of a processing transition (e.g. end of Event), the exception would cause an abort rather than being propagated as expected.
The problem was the Service signal was generated during the destructor of a 'guard' class instance. In C++11 those destructors are now implicitly noexcept(true) which caused the abort.
The destructor were changed to noexcept(false) and a new method 'allowThrow()' was added which is used to avoid throwing an exception while an exception is being propagated out
of the function which uses the guard.
This fix was already introduced to CMSSW_7_0_X but given the large changes between the two releases this had to be reimplemented by hand.