Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch FastCircleFit to use Eigen, generalize FastCircleFit and RZLine interfaces #15260

Merged
merged 7 commits into from Jul 29, 2016
Merged

Switch FastCircleFit to use Eigen, generalize FastCircleFit and RZLine interfaces #15260

merged 7 commits into from Jul 29, 2016

Commits on Jul 20, 2016

  1. Replace TMatrix with Eigen in FastCircleFit, do all calculations in f… 

    …loat

With double precision there would be no changes. Moving at the same to
float incurs numerical differences, but in simple tests those seem to
be smaller than 1 % in the circle parameters. I think this is
acceptable given that the class is called "Fast...".
    @makortel
    makortel committed Jul 20, 2016
    Copy the full SHA
    86a61d8 View commit details
    Browse the repository at this point in the history

  2. Fully inline FastCircleFit 

    Needed for generic interface, especially for avoiding DynArray when
std::array's are given, i.e. we know statically the size.
    @makortel
    makortel committed Jul 20, 2016
    Copy the full SHA
    a798082 View commit details
    Browse the repository at this point in the history

  3. Add DynArray::data()

    @makortel
    makortel committed Jul 20, 2016
    Copy the full SHA
    38185d9 View commit details
    Browse the repository at this point in the history

Commits on Jul 21, 2016

  1. Restructure RZLine calculations, generalize construction, inline

    @makortel
    makortel committed Jul 21, 2016
    Copy the full SHA
    8c94717 View commit details
    Browse the repository at this point in the history

  2. Move to std::array, avoid sqr(sqrt())

    @makortel
    makortel committed Jul 21, 2016
    Copy the full SHA
    d8a7fe3 View commit details
    Browse the repository at this point in the history

  3. Move RZLine.h to interface 

    Since it's already #included outside this package, interface is the
proper place (especially now that the class is header-only)
    @makortel
    makortel committed Jul 21, 2016
    Copy the full SHA
    d8ab96a View commit details
    Browse the repository at this point in the history

Commits on Jul 22, 2016

  1. Document constructor variants

    @makortel
    makortel committed Jul 22, 2016
    Copy the full SHA
    aa86788 View commit details
    Browse the repository at this point in the history