Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Replacing C-style arrays with std::array" #15305

Merged
merged 1 commit into from Jul 28, 2016

Conversation

davidlange6
Copy link
Contributor

Reverts #15241

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @davidlange6 (David Lange) for CMSSW_8_1_X.

It involves the following packages:

DataFormats/HcalRecHit

@cmsbuild, @cvuosalo, @slava77, @davidlange6 can you please review it and eventually sign? Thanks.
@mariadalfonso this is something you requested to watch as well.
@slava77, @smuzaffar you are the release manager for this.

cms-bot commands are list here #13028

@slava77
Copy link
Contributor

slava77 commented Jul 27, 2016

@cmsbuild please test

just to double-check there was no follow up dependent code anywhere [there shouldn't be]

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 27, 2016

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/14262/console

@cmsbuild
Copy link
Contributor

@slava77
Copy link
Contributor

slava77 commented Jul 28, 2016

+1

for #15305 86f675d

  • the feature (std::array) is not supported by ROOT I/O. pre-revert version was tested already, there are no follow up dependencies.

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_1_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @smuzaffar

@davidlange6
Copy link
Contributor Author

+1

@cmsbuild cmsbuild merged commit 96998d7 into CMSSW_8_1_X Jul 28, 2016
@smuzaffar smuzaffar deleted the revert-15241-hbhechannelinfo-array-fix branch October 19, 2016 07:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants