Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modifications to include HLT_DoubleMu0 path in the HeavyFlavor DQM package #15355

Merged
merged 2 commits into from Aug 26, 2016

Conversation

surnairit
Copy link
Contributor

Dear Experts,

Please incorporate the following modifications to include HLT_DoubleMu0 path in the HeavyFlavor DQM package :

208f00d
d6e1a01

We have not made any changes in the c++ code.

Regards,
Nairit

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 2, 2016

A new Pull Request was created by @surnairit for CMSSW_8_0_X.

It involves the following packages:

HLTriggerOffline/HeavyFlavor

@cmsbuild, @dmitrijus, @vanbesien, @davidlange6 can you please review it and eventually sign? Thanks.
@slava77, @smuzaffar you are the release manager for this.

cms-bot commands are list here #13028

@dmitrijus
Copy link
Contributor

+1
(where is 81x port of this?)

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 3, 2016

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/14339/console

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 3, 2016

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_0_X IBs after it passes the integration tests. This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @smuzaffar

@surnairit
Copy link
Contributor Author

@dmitrijus : The 81X PR is here : #15356

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 3, 2016

-1

Tested at: d6e1a01

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-15355/14339/summary.html

I found follow errors while testing this PR

Failed tests: RelVals

  • RelVals:

When I ran the RelVals I found an error in the following worklfows:
140.53 step1

DAS Error

@davidlange6
Copy link
Contributor

@surnairit -please fix the 81x PR - see comments at #15356

@surnairit
Copy link
Contributor Author

Updated PR for 81X is here : #15546

@perrotta
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 23, 2016

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@davidlange6
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 1754587 into cms-sw:CMSSW_8_0_X Aug 26, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants