Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

protect RawTask::_process from processing bad HcalHTRData, backport to 80x #15391

Conversation

dan131riley
Copy link

Backport of #14963 to 80x, requested by @davidlange6

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 8, 2016

A new Pull Request was created by @dan131riley (Dan Riley) for CMSSW_8_0_X.

It involves the following packages:

DQM/HcalTasks

@cmsbuild, @dmitrijus, @vanbesien, @davidlange6 can you please review it and eventually sign? Thanks.
@deguio this is something you requested to watch as well.
@slava77, @smuzaffar you are the release manager for this.

cms-bot commands are list here #13028

@dmitrijus
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 8, 2016

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/14416/console

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 8, 2016

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_0_X IBs after it passes the integration tests. This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @smuzaffar

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 8, 2016

-1

Tested at: d0816c5

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-15391/14416/summary.html

I found follow errors while testing this PR

Failed tests: RelVals

  • RelVals:

When I ran the RelVals I found an error in the following worklfows:
140.53 step1

DAS Error

@davidlange6 davidlange6 merged commit 0aac423 into cms-sw:CMSSW_8_0_X Aug 9, 2016
@dan131riley dan131riley deleted the HcalTasks-rawtask-bad-event-protection-80x branch October 9, 2017 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants