New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Phase2 workflow revamp #15393
Phase2 workflow revamp #15393
Conversation
A new Pull Request was created by @kpedro88 (Kevin Pedro) for CMSSW_8_1_X. It involves the following packages: Calibration/IsolatedParticles @ghellwig, @civanch, @Dr15Jones, @vanbesien, @cvuosalo, @ianna, @mdhildreth, @fabozzi, @cmsbuild, @srimanob, @cerminar, @franzoni, @slava77, @ggovi, @mmusich, @dmitrijus, @hengne, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are list here #13028 |
@cmsbuild please test |
The tests are being triggered in jenkins. |
@slava77 yes, that's correct. Hopefully the customization function will be going away soon. |
@@ -6,3 +6,4 @@ | |||
'standardValidation' : ['prevalidation','validation','validationHarvesting'] | |||
} | |||
|
|||
autoValidation['phase2Validation'] = autoValidation['baseValidation']+autoValidation['trackingOnlyValidation']+autoValidation['muonOnlyValidation'] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
apparently this syntax doesn't work. cmsDriver output with this auto ends up having only the first element baseValidation, while everything else is lost.
I looked at configs in 10624 (baseline) vs 10424 (this PR) and see
|
@slava77 I will try to figure out the problem with DQM/validation this afternoon |
Pull request #15393 was updated. @ghellwig, @civanch, @Dr15Jones, @vanbesien, @cvuosalo, @ianna, @mdhildreth, @fabozzi, @cmsbuild, @srimanob, @cerminar, @franzoni, @slava77, @ggovi, @mmusich, @dmitrijus, @hengne, @davidlange6 can you please check and sign again. |
The tests are being triggered in jenkins. |
+1
|
Hi all - as already discussed in the ORP, please make any further comments on this PR today. Thanks |
This PR reorganizes the Phase2 workflows as discussed in the Upgrade Studies meeting, in preparation for HGCal "cheated" reco.
The new naming scheme is described in Configuration/Geometry/README as requested by @ianna. There is also a new Configuration/Geometry/test with a script to generate 2023 geometries automatically. (For the Phase2 Eras, the only difference is caused by the calorimeter content, so I named them
Phase2C1
andPhase2C2
.)The upgrade workflow matrix numbers have been reorganized. This is reflected in all the necessary configuration files.
Other items of note:
run2_common
is now chained into the Phase2 ErashbheUpgradeReco
andhfUpgradeReco
are no longer used as tags; the reco modules themselves are now replaced usingtoReplaceWith
, so the usualhbhereco
andhfreco
tags for the RecHit collections will continue to work in all downstream recoAll the workflows should still run. I demoted the HGCal workflows back to local reco until the cheated reco is fully ready (@lgray is working on the necessary downstream reco changes).
Don't be intimidated by the apparent size of this PR; ~98% of the changes are in Python...