Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Subjet TagInfo updates (80X) #15394

Conversation

ferencek
Copy link
Contributor

@ferencek ferencek commented Aug 8, 2016

Backport of #15331

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 8, 2016

A new Pull Request was created by @ferencek (Dinko Ferencek) for CMSSW_8_0_X.

It involves the following packages:

PhysicsTools/PatAlgos
RecoBTag/SecondaryVertex

@cmsbuild, @cvuosalo, @slava77, @davidlange6 can you please review it and eventually sign? Thanks.
@TaiSakuma, @imarches, @ahinzmann, @acaudron, @mmarionncern, @rappoccio, @jdolen, @nhanvtran, @gpetruc, @schoef, @ferencek, @mverzett, @mariadalfonso, @pvmulder, @JyothsnaKomaragiri this is something you requested to watch as well.
@slava77, @smuzaffar you are the release manager for this.

cms-bot commands are list here #13028

@cvuosalo
Copy link
Contributor

cvuosalo commented Aug 8, 2016

@cmsbuild please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 8, 2016

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/14426/console

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 9, 2016

-1

Tested at: 1f3a33b

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-15394/14426/summary.html

I found follow errors while testing this PR

Failed tests: RelVals

  • RelVals:

When I ran the RelVals I found an error in the following worklfows:
4.22 step1

DAS Error
140.53 step1
DAS Error

@cvuosalo
Copy link
Contributor

cvuosalo commented Aug 9, 2016

@smuzaffar: Why are 80X Jenkins tests still failing? Could you please check this PR? Thanks.

@smuzaffar
Copy link
Contributor

these are DAS errors, nothing to do with jenkins/test infrastructure.
But I will check why this data is missing.

@cvuosalo
Copy link
Contributor

cvuosalo commented Aug 9, 2016

@cmsbuild please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 9, 2016

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/14447/console

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 9, 2016

-1

Tested at: 1f3a33b

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-15394/14447/summary.html

I found follow errors while testing this PR

Failed tests: RelVals

  • RelVals:

When I ran the RelVals I found an error in the following worklfows:
140.53 step1

DAS Error

@cvuosalo
Copy link
Contributor

cvuosalo commented Aug 9, 2016

+1

For #15394 1f3a33b

Analysis-level enhancement of subjet TagInfos for the SV TagInfo producer. There should be no change in monitored quantities.

#15331 is the 81X version of this PR, and it has already been merged.

The code changes are satisfactory. Jenkins successfully compiled and ran the matrix tests, except for one that is failing because of a file missing from T2_CH_CERN. The comparisons were not run, but they showed no differences in #15331, and this change to analysis code is not expected to cause any differences. A new unit test is included in the PR to test the new features, and the test in Jenkins is successful.

@davidlange6 davidlange6 merged commit 7e24b0b into cms-sw:CMSSW_8_0_X Aug 10, 2016
@ferencek ferencek deleted the SubjetTagInfosNoClustering-PR_from-CMSSW_8_0_12 branch October 6, 2016 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants