New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Subjet TagInfo updates (80X) #15394
Subjet TagInfo updates (80X) #15394
Conversation
…ut intermediate groomed fat jets
A new Pull Request was created by @ferencek (Dinko Ferencek) for CMSSW_8_0_X. It involves the following packages: PhysicsTools/PatAlgos @cmsbuild, @cvuosalo, @slava77, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are list here #13028 |
@cmsbuild please test |
The tests are being triggered in jenkins. |
-1 Tested at: 1f3a33b You can see the results of the tests here: I found follow errors while testing this PR Failed tests: RelVals
When I ran the RelVals I found an error in the following worklfows: DAS Error140.53 step1 DAS Error |
@smuzaffar: Why are 80X Jenkins tests still failing? Could you please check this PR? Thanks. |
these are DAS errors, nothing to do with jenkins/test infrastructure. |
@cmsbuild please test |
The tests are being triggered in jenkins. |
-1 Tested at: 1f3a33b You can see the results of the tests here: I found follow errors while testing this PR Failed tests: RelVals
When I ran the RelVals I found an error in the following worklfows: DAS Error |
+1 Analysis-level enhancement of subjet TagInfos for the SV TagInfo producer. There should be no change in monitored quantities. #15331 is the 81X version of this PR, and it has already been merged. The code changes are satisfactory. Jenkins successfully compiled and ran the matrix tests, except for one that is failing because of a file missing from T2_CH_CERN. The comparisons were not run, but they showed no differences in #15331, and this change to analysis code is not expected to cause any differences. A new unit test is included in the PR to test the new features, and the test in Jenkins is successful. |
Backport of #15331