Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

change das_client.py to das_client in cmsDriver #15400

Merged
merged 1 commit into from Aug 9, 2016
Merged

change das_client.py to das_client in cmsDriver #15400

merged 1 commit into from Aug 9, 2016

Conversation

ghost
Copy link

@ghost ghost commented Aug 9, 2016

Conflicts:
Configuration/Applications/python/ConfigBuilder.py

@davidlange6
change das_client.py to das_client in cmsDriver
e87a96e 
Conflicts:
	Configuration/Applications/python/ConfigBuilder.py
@ghost
Copy link
Author

ghost commented Aug 9, 2016

please test

@cmsbuild cmsbuild added this to the Next CMSSW_7_5_X milestone Aug 9, 2016
@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 9, 2016

A new Pull Request was created by @Degano (Alessandro Degano) for CMSSW_7_5_X.

It involves the following packages:

Configuration/Applications
Configuration/PyReleaseValidation

@franzoni, @fabozzi, @cmsbuild, @srimanob, @hengne, @davidlange6 can you please review it and eventually sign? Thanks.
@ghellwig, @Martin-Grunewald this is something you requested to watch as well.
@slava77, @smuzaffar you are the release manager for this.

cms-bot commands are list here #13028

smuzaffar
smuzaffar reviewed Aug 9, 2016
View reviewed changes
Configuration/Applications/python/ConfigBuilder.py
p = Popen('das_client.py %s --query "%s"'%(option,query), stdout=PIPE,shell=True)
pipe=p.stdout.read()
p = Popen('das_client %s --query "%s"'%(option,query), stdout=PIPE,shell=True)
pipe=p.stdout.read()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like an extra space here?

@smuzaffar
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 9, 2016 •
edited

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/14443/console

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 9, 2016

-1

Tested at: e87a96e

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-15400/14443/summary.html

I found follow errors while testing this PR

Failed tests: RelVals

  • RelVals:

When I ran the RelVals I found an error in the following worklfows:
140.53 step1

DAS Error

@davidlange6 davidlange6 merged commit ba9cc10 into cms-sw:CMSSW_7_5_X Aug 9, 2016
@ghost ghost deleted the fix_das_client_75X branch August 10, 2016 09:09
@smuzaffar smuzaffar mentioned this pull request Aug 16, 2016
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
comparison-pending operations-pending orp-pending pdmv-pending pending-signatures tests-rejected
Projects
None yet
Milestone
CMSSW_7_5_X
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@cmsbuild @smuzaffar @davidlange6