fix duplicate customise_commands in cmsDriver #15418
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For a while, I've noticed that using
customise_commands
incmsDriver
resulted in the commands being printed twice at the end of the generated config. The handling of this was changed most recently in #6492.I finally found the cause of the duplication: the second call to
addCustomise()
for unscheduled mode was in the wrong block for the current logic. The fixed version works for both the example in #6492 and regular (scheduled) examples, e.g.: