Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add documentation to CSC and GEM digi dataformats #15441

Merged
merged 4 commits into from Aug 15, 2016
Merged

Add documentation to CSC and GEM digi dataformats #15441

merged 4 commits into from Aug 15, 2016

Conversation

dildick
Copy link
Contributor

@dildick dildick commented Aug 12, 2016

In this pull request:

  • The conversion of (strip number, comparator reading) to halfstrip number is frequently done in the CSC trigger and DAQ step. The implementation here is based on the definition used in the function CSCCLCTData::add() in EventFilter/CSCRawToDigi.
  • I added some extra documentation in the interface of CSC and GEM digi dataformats to clarify whether a strip/wire/pad counts from 0 or 1.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @dildick (Sven Dildick) for CMSSW_8_1_X.

It involves the following packages:

DataFormats/CSCDigi

@cmsbuild, @civanch, @mdhildreth, @davidlange6 can you please review it and eventually sign? Thanks.
@ptcox this is something you requested to watch as well.
@slava77, @smuzaffar you are the release manager for this.

cms-bot commands are list here #13028

@dildick dildick changed the title Add function getHalfStrip to CSCComparatorDigi Add documentation to CSC and GEM digi dataformats Aug 12, 2016
@civanch
Copy link
Contributor

civanch commented Aug 12, 2016

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 12, 2016

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/14493/console

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-15441/14493/summary.html

@slava77 comparisons for the following workflows were not done due to missing matrix map:

  • 10424.0_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2023D1_GenSimFull+DigiFull_2023D1+RecoFullGlobal_2023D1+HARVESTFullGlobal_2023D1

@civanch
Copy link
Contributor

civanch commented Aug 12, 2016

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_1_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @smuzaffar

@davidlange6
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 5b220e7 into cms-sw:CMSSW_8_1_X Aug 15, 2016
@dildick dildick deleted the from-CMSSW_8_1_0_pre9-csc-trigger-add-documentation branch October 20, 2016 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants