Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switching BoostedDoubleSV tagger to v3 training (80X) #15446

Conversation

ferencek
Copy link
Contributor

Backport of #15445

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @ferencek (Dinko Ferencek) for CMSSW_8_0_X.

It involves the following packages:

RecoBTag/SecondaryVertex

@cmsbuild, @cvuosalo, @slava77, @davidlange6 can you please review it and eventually sign? Thanks.
@imarches, @acaudron, @JyothsnaKomaragiri, @mverzett, @ferencek, @pvmulder this is something you requested to watch as well.
@slava77, @smuzaffar you are the release manager for this.

cms-bot commands are list here #13028

@slava77
Copy link
Contributor

slava77 commented Aug 12, 2016

@cmsbuild please test
looks like the files are in the IB already

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 12, 2016

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/14499/console

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@slava77
Copy link
Contributor

slava77 commented Aug 17, 2016

This PR changes miniAOD content (in pfBoostedDoubleSecondaryVertexAK8BJetTagsAK8 or its upcoming replacement pfBoostedDoubleSecondaryVertexAK8BJetTagsAK8Puppi ).
So, this will be put on hold until rereco/reminiAOD release is being made.

@slava77
Copy link
Contributor

slava77 commented Aug 17, 2016

hold

@cmsbuild
Copy link
Contributor

Pull request has been put on hold by @slava77
They need to issue an unhold command to remove the hold state or L1 can unhold it for all

@cmsbuild cmsbuild added the hold label Aug 17, 2016
@slava77
Copy link
Contributor

slava77 commented Aug 17, 2016

+1

for #15446 ccd3201

  • code changes are in line with the PR title; a tagger used for AK8 jets in miniAOD and for CA 1.5 for analysis are updated. This is a verbatim backport from 81X Switching BoostedDoubleSV tagger to v3 training #15445
  • jenkins tests pass and comparisons with baseline show no differences (the values in pfBoostedDoubleSecondaryVertexAK8BJetTagsAK8 are not monitored)

the PR is put on hold due to changes in miniAOD. It will be ready to be merged once changes in miniAOD are allowed.

@davidlange6 davidlange6 merged commit d242c92 into cms-sw:CMSSW_8_0_X Sep 7, 2016
@ferencek ferencek deleted the BoostedDoubleSVTaggerV3-PR_from-CMSSW_8_0_8_patch1 branch September 12, 2016 00:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants