Hip monitoring (80x) #15449
Hip monitoring (80x) #15449
Conversation
|
A new Pull Request was created by @mtosi (mia tosi) for CMSSW_8_0_X. It involves the following packages: DQM/TrackingMonitor @cmsbuild, @dmitrijus, @vanbesien, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are list here #13028 |
|
@cmsbuild , please test |
|
The tests are being triggered in jenkins. |
cmsbuild
added
tests-started
tests-pending
and removed
tests-pending
tests-started
labels
|
Pull request #15449 was updated. @cmsbuild, @dmitrijus, @vanbesien, @davidlange6 can you please check and sign again. |
6 similar comments
|
Pull request #15449 was updated. @cmsbuild, @dmitrijus, @vanbesien, @davidlange6 can you please check and sign again. |
|
Pull request #15449 was updated. @cmsbuild, @dmitrijus, @vanbesien, @davidlange6 can you please check and sign again. |
|
Pull request #15449 was updated. @cmsbuild, @dmitrijus, @vanbesien, @davidlange6 can you please check and sign again. |
|
Pull request #15449 was updated. @cmsbuild, @dmitrijus, @vanbesien, @davidlange6 can you please check and sign again. |
|
Pull request #15449 was updated. @cmsbuild, @dmitrijus, @vanbesien, @davidlange6 can you please check and sign again. |
|
Pull request #15449 was updated. @cmsbuild, @dmitrijus, @vanbesien, @davidlange6 can you please check and sign again. |
| @@ -110,7 +127,8 @@ TrackingMonitor::TrackingMonitor(const edm::ParameterSet& iConfig) | |||
| if ( doPlotsVsBXlumi_ ) | |||
| theLumiDetails_ = new GetLumi( iConfig.getParameter<edm::ParameterSet>("BXlumiSetup"), c ); | |||
There was a problem hiding this comment.
Make theLumiDetails_ a unique_ptr? I feel uncomfortable around unfreed object.
|
+1 |
cmsbuild
added
dqm-approved
fully-signed
and removed
dqm-pending
pending-signatures
labels
|
The tests are being triggered in jenkins. |
|
This pull request is fully signed and it will be integrated in one of the next CMSSW_8_0_X IBs after it passes the integration tests. This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @smuzaffar |
|
This pull request is fully signed and it will be integrated in one of the next CMSSW_8_0_X IBs after it passes the integration tests. This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @smuzaffar |
|
as a reminder: to get consistent results #15513 needs to be merged first |
80X: updating SiStrip DQM TriggerBits for HIP monitoring (PR #15449)
|
please test |
|
The tests are being triggered in jenkins. |
cmsbuild
added
tests-pending
comparison-pending
tests-started
and removed
comparison-available
tests-approved
tests-pending
labels
|
@mtosi as expected after #15513 has been merged, warnings disappear, please cf. vs: @dmitrijus this PR is ready to be asked at the ORP today. |
|
thanks much On Tue, Aug 30, 2016 at 9:52 AM, Marco Musich notifications@github.com
|
|
+1 |
|
thanks ! |
backport of PR #15447
in addition I add the #14900
because that is part of the monitoring needed for the hip
and it has not been merged yet
please, this is urgent for the hip monitoring
I hope there are no issues w/ the integration
he needed 3 new "keys" in the AlCaRecoTriggerBitsRcd payload
should be added by arun.kumar@cern.ch as discussed w/ @mmusich
as soon as the PR is integrated in 80x
the corresponding trigger paths should be integrated in the next days
as described in https://its.cern.ch/jira/browse/CMSHLT-981
I really hope (and somehow request) to have this PR integrated w/in few days
because we need this plots by next week in the GUI for the studies related to the hip
as requested by the HIP task force
@dmitrijus @vanbesien
thanks much