Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update edmPickEvents since das_client can not be imported #15479

Merged
merged 1 commit into from Aug 16, 2016

Conversation

davidlange6
Copy link
Contributor

some work needed I think. - but this version works again
@VinInn

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @davidlange6 (David Lange) for CMSSW_8_1_X.

It involves the following packages:

PhysicsTools/Utilities

@cmsbuild, @davidlange6 can you please review it and eventually sign? Thanks.
@slava77, @smuzaffar you are the release manager for this.

cms-bot commands are list here #13028

@davidlange6
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 16, 2016

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/14537/console

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@davidlange6
Copy link
Contributor Author

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_1_X IBs (tests are also fine). This pull request will be automatically merged.

@cmsbuild cmsbuild merged commit 562a627 into cms-sw:CMSSW_8_1_X Aug 16, 2016
@nsmith-
Copy link
Contributor

nsmith- commented Aug 24, 2016

If das_client.py in the CMSSW python path gets updated to a new version (v02.17.04-giojec or newer), then this patch would work:

diff --git a/PhysicsTools/Utilities/scripts/edmPickEvents.py b/PhysicsTools/Utilities/scripts/edmPickEvents.py
index 6771946..305a874 100755
--- a/PhysicsTools/Utilities/scripts/edmPickEvents.py
+++ b/PhysicsTools/Utilities/scripts/edmPickEvents.py
@@ -87,7 +87,7 @@ def getFileNames (event):
     files = []
     # Query DAS
     query = "file dataset=%(dataset)s run=%(run)i lumi=%(lumi)i | grep file.name" % event
-    jsondict = das_client.get_data('https://cmsweb.cern.ch', query, 0, 0, False)
+    jsondict = das_client.get_data('https://cmsweb.cern.ch', query, 0, 0, False, ckey=das_client.x509(), cert=das_client.x509())
     status = jsondict['status']
     if status != 'ok':
         print "DAS query status: %s"%(status)

Also, I noticed the method in das_client shell script to pick newest version will prefer v02.17.04 to v02.17.04-giojec. Perhaps that is intentional to limit to full releases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants