Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport to 80X: Flip the soft lepton sIP in case the Negative CTagger is used #15510

Conversation

smoortga
Copy link
Contributor

This is a backport to CMSSW_8_0_X of the recent commit #15478 (which was in CMSSW_8_1_X) and which was merged today (18 August 2016).

@mverzett, @kovitang and @monttj are interested in following this PR

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @smoortga for CMSSW_8_0_X.

It involves the following packages:

RecoBTag/CTagging
RecoBTag/SecondaryVertex

@cmsbuild, @cvuosalo, @slava77, @davidlange6 can you please review it and eventually sign? Thanks.
@imarches, @acaudron, @JyothsnaKomaragiri, @mverzett, @ferencek, @pvmulder this is something you requested to watch as well.
@slava77, @smuzaffar you are the release manager for this.

cms-bot commands are list here #13028

@cvuosalo
Copy link
Contributor

@cmsbuild please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 18, 2016

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/14592/console

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@cvuosalo
Copy link
Contributor

backport #15478

@cvuosalo
Copy link
Contributor

+1

For #15510 897d1ea

Allow sign flipping of the softElectron and softMuon impact parameters for the negative c tagger. There should be no change in monitored RECO quantities.

#15478 is the 81X version of this PR, and it has already been merged.

The code changes are satisfactory, and Jenkins tests against baseline CMSSW_8_0_X_2016-08-18-1100 show no significant differences, as expected.

@davidlange6
Copy link
Contributor

+1

@davidlange6
Copy link
Contributor

+1

@davidlange6 davidlange6 merged commit 9324dd2 into cms-sw:CMSSW_8_0_X Aug 26, 2016
@davidlange6
Copy link
Contributor

@smuzaffar - seems the bot is confused here - it thinks there are signatures pending for some reason?

@smuzaffar
Copy link
Contributor

humm, may be due to backport label. I am looking

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_0_X IBs (tests are also fine). This pull request will be automatically merged.

@smuzaffar
Copy link
Contributor

fixed (new labels urgent, bug-fix, backport and new-features were blocking the removal of pending-signatures)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants