New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Backport to 80X: Flip the soft lepton sIP in case the Negative CTagger is used #15510
Backport to 80X: Flip the soft lepton sIP in case the Negative CTagger is used #15510
Conversation
A new Pull Request was created by @smoortga for CMSSW_8_0_X. It involves the following packages: RecoBTag/CTagging @cmsbuild, @cvuosalo, @slava77, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are list here #13028 |
@cmsbuild please test |
The tests are being triggered in jenkins. |
backport #15478 |
+1 Allow sign flipping of the softElectron and softMuon impact parameters for the negative c tagger. There should be no change in monitored RECO quantities. #15478 is the 81X version of this PR, and it has already been merged. The code changes are satisfactory, and Jenkins tests against baseline CMSSW_8_0_X_2016-08-18-1100 show no significant differences, as expected. |
+1 |
+1 |
@smuzaffar - seems the bot is confused here - it thinks there are signatures pending for some reason? |
humm, may be due to backport label. I am looking |
This pull request is fully signed and it will be integrated in one of the next CMSSW_8_0_X IBs (tests are also fine). This pull request will be automatically merged. |
fixed (new labels urgent, bug-fix, backport and new-features were blocking the removal of pending-signatures) |
This is a backport to CMSSW_8_0_X of the recent commit #15478 (which was in CMSSW_8_1_X) and which was merged today (18 August 2016).
@mverzett, @kovitang and @monttj are interested in following this PR