Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for Tracker Maps and Shifter Summary #15515

Merged
merged 2 commits into from Aug 24, 2016
Merged

Fix for Tracker Maps and Shifter Summary #15515

merged 2 commits into from Aug 24, 2016

Conversation

fioriNTU
Copy link
Contributor

Fix in SiStripUtility to take into account the new IsolatedBunches directory in SiStrip workspace
Taking the opportunity to update the tk map script and add a template cfg to be used by Tracker Offline Shifters

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @fioriNTU for CMSSW_8_0_X.

It involves the following packages:

DQM/SiStripMonitorClient

@cmsbuild, @dmitrijus, @vanbesien, @davidlange6 can you please review it and eventually sign? Thanks.
@idebruyn, @threus, @hdelanno, @venturia this is something you requested to watch as well.
@slava77, @smuzaffar you are the release manager for this.

cms-bot commands are list here #13028

@fioriNTU
Copy link
Contributor Author

If possible this should go in the first patch realese for production, it fixes the Top Summary for shifters that at the moment in Offline DQM shows a fake status of 100% green

@cmsbuild
Copy link
Contributor

Pull request #15515 was updated. @cmsbuild, @dmitrijus, @vanbesien, @davidlange6 can you please check and sign again.

@davidlange6
Copy link
Contributor

@fioriNTU - needs to be in 81x first - is there a PR?

@boudoul
Copy link
Contributor

boudoul commented Aug 19, 2016

yes it was already referenced in the conversation : I can remind it here : PR #15517

@fioriNTU
Copy link
Contributor Author

yes, here #15517 sorry for not linking

Il 19/08/2016 10.48, David Lange ha scritto:

@fioriNTU https://github.com/fioriNTU - needs to be in 81x first -
is there a PR?


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#15515 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AKYUWoOQ0yLU90ePkFg8d-htmPVKtAUmks5qhW3RgaJpZM4JnjRL.

@davidlange6
Copy link
Contributor

thanks - I just missed it

On Aug 19, 2016, at 11:23 AM, fioriNTU notifications@github.com wrote:

yes, here #15517 sorry for not linking

Il 19/08/2016 10.48, David Lange ha scritto:

@fioriNTU https://github.com/fioriNTU - needs to be in 81x first -
is there a PR?


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#15515 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AKYUWoOQ0yLU90ePkFg8d-htmPVKtAUmks5qhW3RgaJpZM4JnjRL.


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

@venturia
Copy link
Contributor

when we (Tracker) change the DQM code we should check the impact up to the shifter Tracker map production. I don't think this can be included in any (semi-)automatic validation procedure

@dmitrijus
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 23, 2016

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/14679/console

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_0_X IBs after it passes the integration tests. This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @smuzaffar

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@davidlange6
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit e09ca1d into cms-sw:CMSSW_8_0_X Aug 24, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants