Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use unique_ptr, not auto_ptr, in PhysicsTools packages #15522

Merged
merged 1 commit into from Aug 20, 2016

Conversation

wmtan
Copy link
Contributor

@wmtan wmtan commented Aug 18, 2016

In preparation for removing framework support for deprecated auto_ptr arguments in put() calls, this pull request replaces the use of auto_ptr with unique_ptr in PhysicsTools packages. Also, std::make_unique is used when appropriate.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @wmtan for CMSSW_8_1_X.

It involves the following packages:

PhysicsTools/CandAlgos
PhysicsTools/HepMCCandAlgos
PhysicsTools/IsolationAlgos
PhysicsTools/JetCharge
PhysicsTools/JetMCAlgos
PhysicsTools/PatAlgos
PhysicsTools/PatExamples
PhysicsTools/PatUtils
PhysicsTools/RecoAlgos
PhysicsTools/SelectorUtils
PhysicsTools/TagAndProbe
PhysicsTools/UtilAlgos

@cmsbuild, @cvuosalo, @slava77, @montjj, @davidlange6 can you please review it and eventually sign? Thanks.
@TaiSakuma, @imarches, @ahinzmann, @acaudron, @mmarionncern, @rappoccio, @jdolen, @nhanvtran, @gpetruc, @schoef, @ferencek, @mverzett, @mariadalfonso, @pvmulder, @JyothsnaKomaragiri this is something you requested to watch as well.
@slava77, @smuzaffar you are the release manager for this.

cms-bot commands are list here #13028

@wmtan
Copy link
Contributor Author

wmtan commented Aug 19, 2016

@cmsbuild please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 19, 2016

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/14597/console

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@cvuosalo
Copy link
Contributor

+1

For #15522 42945c4

PhysicsTools migration of deprecated auto_ptr to unique_ptr. There should be no change in run-time behavior.

The code changes are satisfactory, and Jenkins tests against baseline CMSSW_8_1_X_2016-08-18-2300 show no significant differences, as expected.

@davidlange6 davidlange6 merged commit fc154dd into cms-sw:CMSSW_8_1_X Aug 20, 2016
@wmtan wmtan deleted the UseUniquePtrInPhysicsTools branch September 4, 2016 02:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants