Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix throwing CapacityExausted #15529

Merged
merged 3 commits into from Aug 23, 2016
Merged

Fix throwing CapacityExausted #15529

merged 3 commits into from Aug 23, 2016

Conversation

VinInn
Copy link
Contributor

@VinInn VinInn commented Aug 20, 2016

catch "buffer full" before insertion (as in pre-threadSafe version).
print LogError (as in pre-threadSafe version).
tested with runTheMatrix and addOnTests.py -t hlt_data_GRun reducing the capacity to 10K...

will recompile the universe

@VinInn
Copy link
Contributor Author

VinInn commented Aug 20, 2016

@cmsbuild , please test

@VinInn
Copy link
Contributor Author

VinInn commented Aug 20, 2016

@fwyzard , @mtosi, @rovere FYI

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 20, 2016

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/14613/console

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @VinInn (Vincenzo Innocente) for CMSSW_8_1_X.

It involves the following packages:

DataFormats/Common
RecoLocalTracker/SiStripClusterizer

@smuzaffar, @Dr15Jones, @cvuosalo, @cmsbuild, @slava77, @davidlange6 can you please review it and eventually sign? Thanks.
@wmtan, @makortel, @forthommel, @yduhm, @GiacomoSguazzoni, @gbenelli, @rovere, @VinInn, @nickmccoll, @jlagram, @wddgit, @gpetruc, @OlivierBondu, @threus this is something you requested to watch as well.
@slava77, @smuzaffar you are the release manager for this.

cms-bot commands are list here #13028

@Dr15Jones
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

-1

Tested at: 29a097f

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-15529/14613/summary.html

I found follow errors while testing this PR

Failed tests: UnitTests

  • Unit Tests:

I found errors in the following unit tests:

---> test TestRunnerPhysicsToolsCondLiteIO had ERRORS

@cmsbuild
Copy link
Contributor

@slava77
Copy link
Contributor

slava77 commented Aug 22, 2016

+1

for #15529 29a097f

  • change is in line with description
  • jenkins tests pass and comparisons with baseline show no difference
  • the unit test failure is unrelated to this PR

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_1_X IBs (but tests are reportedly failing). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @smuzaffar

@davidlange6 davidlange6 merged commit 55471ec into cms-sw:CMSSW_8_1_X Aug 23, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants