Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding general track to ALCARECO for muonalign #15556

Merged
merged 5 commits into from Oct 6, 2016

Conversation

lpernie
Copy link
Contributor

@lpernie lpernie commented Aug 22, 2016

Hi @mmusich,
This the new PR on the addition of general tracks to the ALCARECO stream for muon alignment you requested on 80X.
It follows the PR in #15221.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @lpernie (Luca) for CMSSW_8_0_X.

It involves the following packages:

Alignment/CommonAlignmentProducer
Configuration/PyReleaseValidation
Configuration/StandardSequences

@ghellwig, @franzoni, @cerminar, @fabozzi, @cmsbuild, @srimanob, @mmusich, @hengne, @davidlange6 can you please review it and eventually sign? Thanks.
@ghellwig, @pakhotin, @makortel, @GiacomoSguazzoni, @tocheng, @VinInn, @Martin-Grunewald, @rovere, @tlampen, @mschrode, @mmusich, @dgulhan this is something you requested to watch as well.
@slava77, @smuzaffar you are the release manager for this.

cms-bot commands are list here #13028

@lpernie lpernie changed the title first commit Adding general track to ALCARECO for muonalign Aug 22, 2016
@franzoni
Copy link

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 22, 2016

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/14650/console

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 1, 2016

Pull request #15556 was updated. @ghellwig, @vanbesien, @franzoni, @cerminar, @dmitrijus, @cmsbuild, @srimanob, @mmusich, @fabozzi, @hengne, @davidlange6 can you please check and sign again.

@mmusich
Copy link
Contributor

mmusich commented Sep 1, 2016

lpernie@11801a3 needs to be first in 81x. Thanks @lpernie

@mmusich
Copy link
Contributor

mmusich commented Sep 1, 2016

please test

@lpernie
Copy link
Contributor Author

lpernie commented Sep 15, 2016

@mmusich Done!

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@mmusich
Copy link
Contributor

mmusich commented Sep 16, 2016

backport of #15221 and #15753

@mmusich
Copy link
Contributor

mmusich commented Sep 16, 2016

+1

@dmitrijus
Copy link
Contributor

+1

@fabozzi
Copy link
Contributor

fabozzi commented Sep 16, 2016

+1

@franzoni
Copy link

franzoni commented Oct 4, 2016

+1

ok both for AlCa (already signed) and for operations

(simply adding 3 needed sequences:
pathALCARECOMuAlCalIsolatedMuGeneralTracks pathALCARECOMuAlZMuMuGeneralTracks pathALCARECOMuAlOverlapsGeneralTracks
to: AlCaRecoStreams_cff.py
)

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 4, 2016

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_0_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @smuzaffar

@davidlange6
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 1055b2a into cms-sw:CMSSW_8_0_X Oct 6, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants