Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keep lumi from scalers #15585

Merged
merged 1 commit into from Aug 26, 2016
Merged

Conversation

gpetruc
Copy link
Contributor

@gpetruc gpetruc commented Aug 24, 2016

No description provided.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @gpetruc (Giovanni Petrucciani) for CMSSW_8_1_X.

It involves the following packages:

PhysicsTools/PatAlgos

@cmsbuild, @cvuosalo, @slava77, @montjj, @davidlange6 can you please review it and eventually sign? Thanks.
@TaiSakuma, @imarches, @ahinzmann, @acaudron, @mmarionncern, @rappoccio, @jdolen, @nhanvtran, @JyothsnaKomaragiri, @schoef, @ferencek, @mverzett, @mariadalfonso, @pvmulder this is something you requested to watch as well.
@slava77, @smuzaffar you are the release manager for this.

cms-bot commands are list here #13028

@davidlange6
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 25, 2016

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/14725/console

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@cvuosalo
Copy link
Contributor

+1

For #15585 24fae4e

Add lumi scalers to Mini-AOD. There should be no change in monitored quantities.

The code change is satisfactory, and Jenkins tests against baseline CMSSW_8_1_X_2016-08-24-2300 show no significant differences, as expected. A test of workflow 134.805_RunMET2015C with 20 events against baseline CMSSW_8_1_0_pre10 also shows no significant differences, and it confirms that the lumi scalers have been added to Mini-AOD:

-----------------------------------------------------------------
   or, B         new, B      delta, B   delta, %   deltaJ, %    branch 
-----------------------------------------------------------------
      0.0 ->      1995.8       1996     NEWO   1.54     LumiScalerss_scalersRawToDigi__reRECO.
-------------------------------------------------------------
   129272 ->      131268       1996             1.5     ALL BRANCHES

@davidlange6 davidlange6 merged commit 58e9151 into cms-sw:CMSSW_8_1_X Aug 26, 2016
@gpetruc gpetruc deleted the addLumiScalers-81X branch August 26, 2016 14:56
@gpetruc gpetruc mentioned this pull request Aug 26, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants