New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
First version of PFCal geometry description #1559
Conversation
This pull request is fully signed and it will be integrated in one of the next IBs unless changes or unless it breaks tests. @davidlange6 can you please take care of it? |
@pfs - Pedro, please, use the naming conventions as discussed. I'll start with this structure to integrate PFCal in a full CMS geometry scenario for 2019. |
…to be able replace HE and EE with PFCal.
A new Pull Request was created by @ianna for CMSSW_6_2_X_SLHC. First version of PFCal geometry description It involves the following packages: Geometry/EcalCommonData @civanch, @Dr15Jones, @ianna, @mdhildreth, @cmsbuild, @nclopezo, @ktf can you please review it and eventually sign? Thanks. |
Pull request #1559 was updated. @civanch, @Dr15Jones, @ianna, @mdhildreth, @cmsbuild, @nclopezo, @ktf can you please check and sign again. |
Pull request #1559 was updated. @civanch, @Dr15Jones, @ianna, @mdhildreth, @cmsbuild, @nclopezo, @ktf can you please check and sign again. |
@pfs - to dump geometry for visualization: cmsRun Geometry/PFCalGeometry/test/dumpExtended2019PFCalGeometry_cfg.py |
Pull request #1559 was updated. @civanch, @Dr15Jones, @ianna, @mdhildreth, @cmsbuild, @nclopezo, @ktf can you please check and sign again. |
@ianna - thanks you very much. |
@vandreev11 Please, take this branch on top of CMSSW_6_2_0_SLHC4. To dump geometry for visualization: cmsRun Geometry/PFCalGeometry/test/dumpExtended2019PFCalGeometry_cfg.py |
… have been eliminated.
@pfs and @vandreev11 Please, use updated branch. The overlaps with PFCal have been eliminated. |
Pull request #1559 was updated. @civanch, @Dr15Jones, @ianna, @mdhildreth, @cmsbuild, @nclopezo, @ktf can you please check and sign again. |
Pull request #1559 was updated. @civanch, @Dr15Jones, @ianna, @mdhildreth, @cmsbuild, @nclopezo, @ktf can you please check and sign again. |
@pfs and @vandreev11 - the updates on this branch include, as agreed this morning:
After checking out and building this branch on top of CMSSW_6_2_0_SLHC4 the following command works for the step1: runTheMatrix.py -l 2.0 --command "--geometry Extended2023 --conditions auto:upgradePLS3" |
+1 On 11/27/13 3:58 PM, cmsbuild wrote:
CERN Office: 40-3-A28 tel: +41 22 767 1209 CERN CMS Secretariat fax: +41 22 767 8940 |
@pfs and @vandreev11 - DIGI and RECO will require some more work on customization. I'll commit an update for Reco geometries, but the digi producers will need to be configured with BarrelOnly=True to avoid the following exception:
|
+1 |
@ianna Thank you very much. A question is |
@pfs yes, these are the constants for all ECal and are re-used in other places it seems. |
can you please send me a private email directly when you guys reached a Cheers, On 11/28/13 12:08 PM, cmsbuild wrote:
CERN Office: 40-3-A28 tel: +41 22 767 1209 CERN CMS Secretariat fax: +41 22 767 8940 |
@ianna - (correctly a private mail a bit) for the moment at least, lets call this geometry (for cmsDriver purposes at least) Extended2023PFCal or Extended2023HGCal - presumably we will "soon" have several of these and this way its clear from the name what calorimeter is used. (will also need a "default" Extended2023, but not that far along yet) |
@vandreev11 - now you have both HGCalEE and HGCalHE defined. Please, use them as parent volumes for pfcal children. |
@vandreev11 and @pfs - note, the total number of volumes is the same, but there are twice less defined in xml (only ZP). This is due to positioning in HE mother volume, which is then placed twice. The difference is that volume copies are places clockwise looking at end-cap from IP for both +Z and -Z. @davidlange6 - Please, take it to the next SLHC release. I'll open another branch to fix overlaps in Extended2023 scenario. It will be based on this one. |
+1 |
First version of PFCal geometry description
Note: The xml description uses legacy algorithm in its description and this will not work in 70x series. PFCalo experts are working on migrating it to a new algorithm.