Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

First version of PFCal geometry description #1559

Merged
merged 21 commits into from Dec 9, 2013

Conversation

ianna
Copy link
Contributor

@ianna ianna commented Nov 22, 2013

  • The first version of PFCalo geometry description from Pedro Silva
  • Configurations to display it

Note: The xml description uses legacy algorithm in its description and this will not work in 70x series. PFCalo experts are working on migrating it to a new algorithm.

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next IBs unless changes or unless it breaks tests. @davidlange6 can you please take care of it?

@ianna
Copy link
Contributor Author

ianna commented Nov 22, 2013

@pfs - Pedro, please, use the naming conventions as discussed. I'll start with this structure to integrate PFCal in a full CMS geometry scenario for 2019.
Yana

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @ianna for CMSSW_6_2_X_SLHC.

First version of PFCal geometry description

It involves the following packages:

Geometry/EcalCommonData
Geometry/HcalCommonData
Geometry/PFCalGeometry
Geometry/CMSCommonData

@civanch, @Dr15Jones, @ianna, @mdhildreth, @cmsbuild, @nclopezo, @ktf can you please review it and eventually sign? Thanks.
@ghellwig this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@davidlange6 you are the release manager for this.

@cmsbuild
Copy link
Contributor

Pull request #1559 was updated. @civanch, @Dr15Jones, @ianna, @mdhildreth, @cmsbuild, @nclopezo, @ktf can you please check and sign again.

@cmsbuild
Copy link
Contributor

Pull request #1559 was updated. @civanch, @Dr15Jones, @ianna, @mdhildreth, @cmsbuild, @nclopezo, @ktf can you please check and sign again.

@ianna
Copy link
Contributor Author

ianna commented Nov 25, 2013

@pfs - to dump geometry for visualization:

cmsRun Geometry/PFCalGeometry/test/dumpExtended2019PFCalGeometry_cfg.py

@cmsbuild
Copy link
Contributor

Pull request #1559 was updated. @civanch, @Dr15Jones, @ianna, @mdhildreth, @cmsbuild, @nclopezo, @ktf can you please check and sign again.

@pfs
Copy link
Contributor

pfs commented Nov 25, 2013

@ianna - thanks you very much.
I'll merge locally in my development area. Your pfcalo-geometry branch should be the one to pick up right?
Is there a cfg which I could pick up to generate locally a SIM sample to test my developments on the geometry?
Shall I use cmsDriver.py?

@ianna
Copy link
Contributor Author

ianna commented Nov 27, 2013

@vandreev11 Please, take this branch on top of CMSSW_6_2_0_SLHC4. To dump geometry for visualization:

cmsRun Geometry/PFCalGeometry/test/dumpExtended2019PFCalGeometry_cfg.py

@ianna
Copy link
Contributor Author

ianna commented Nov 27, 2013

@pfs and @vandreev11 Please, use updated branch. The overlaps with PFCal have been eliminated.

@cmsbuild
Copy link
Contributor

Pull request #1559 was updated. @civanch, @Dr15Jones, @ianna, @mdhildreth, @cmsbuild, @nclopezo, @ktf can you please check and sign again.

@cmsbuild
Copy link
Contributor

Pull request #1559 was updated. @civanch, @Dr15Jones, @ianna, @mdhildreth, @cmsbuild, @nclopezo, @ktf can you please check and sign again.

@cmsbuild
Copy link
Contributor

Pull request #1559 was updated. @civanch, @nclopezo, @vlimant, @ianna, @mdhildreth, @ktf, @cmsbuild, @franzoni, @Dr15Jones, @fabiocos can you please check and sign again.

@ianna
Copy link
Contributor Author

ianna commented Nov 27, 2013

@pfs and @vandreev11 - the updates on this branch include, as agreed this morning:

  • GEM materials at the top level in materials.xml file in order to be reused by PFCal
  • Overlaps in Calo with PFCalo have been fixed. Note, there are other overlaps, but they are unrelated to the newly defined detector. I'll look into it.
  • Extended2023 scenario is based on BE5D tracker and does not include ES, EE, nor HE
  • Extended2023 geometry label is defined for cmsDriver

After checking out and building this branch on top of CMSSW_6_2_0_SLHC4 the following command works for the step1:

runTheMatrix.py -l 2.0 --command "--geometry Extended2023 --conditions auto:upgradePLS3"

@vlimant
Copy link
Contributor

vlimant commented Nov 27, 2013

+1

On 11/27/13 3:58 PM, cmsbuild wrote:

Pull request #1559 #1559 was
updated. @civanch https://github.com/civanch, @nclopezo
https://github.com/nclopezo, @vlimant https://github.com/vlimant,
@ianna https://github.com/ianna, @mdhildreth
https://github.com/mdhildreth, @ktf https://github.com/ktf,
@cmsbuild https://github.com/cmsbuild, @franzoni
https://github.com/franzoni, @Dr15Jones
https://github.com/Dr15Jones, @fabiocos https://github.com/fabiocos
can you please check and sign again.


Reply to this email directly or view it on GitHub
#1559 (comment).


           ** Dr. Jean-Roch VLIMANT **
   CMS experiment,  CERN - Physics department

CERN Office: 40-3-A28 tel: +41 22 767 1209

CERN CMS Secretariat fax: +41 22 767 8940

@cmsbuild
Copy link
Contributor

Pull request #1559 was updated. @civanch, @nclopezo, @vlimant, @ianna, @mdhildreth, @ktf, @cmsbuild, @franzoni, @Dr15Jones, @fabiocos can you please check and sign again.

@ianna
Copy link
Contributor Author

ianna commented Nov 27, 2013

@pfs and @vandreev11 - DIGI and RECO will require some more work on customization. I'll commit an update for Reco geometries, but the digi producers will need to be configured with BarrelOnly=True to avoid the following exception:

27-Nov-2013 16:52:44 CET  Successfully opened file file:step1.root
----- Begin Fatal Exception 27-Nov-2013 16:53:00 CET-----------------------
An exception of category 'NoRecord' occurred while
   [0] Processing run: 1
   [1] Running path 'digitisation_step'
   [2] Calling beginRun for module EcalTrigPrimProducer/'simEcalTriggerPrimitiveDigis'
Exception Message:
No "EcalEndcapGeometryRecord" record found in the EventSetup.
 Please add an ESSource or ESProducer that delivers such a record.
----- End Fatal Exception -------------------------------------------------
Another exception was caught while trying to clean up files after the primary fatal exception.

@ianna
Copy link
Contributor Author

ianna commented Nov 27, 2013

+1

@pfs
Copy link
Contributor

pfs commented Nov 27, 2013

@ianna Thank you very much. A question is
Geometry/EcalCommonData/data/eecon.xml
needed in
cmsExtendedGeometry2023HGCalXML_cfi.py ?

@cmsbuild
Copy link
Contributor

Pull request #1559 was updated. @cmsbuild, @franzoni, @nclopezo, @fabiocos, @vlimant can you please check and sign again.

@ianna
Copy link
Contributor Author

ianna commented Nov 28, 2013

@pfs yes, these are the constants for all ECal and are re-used in other places it seems.

@cmsbuild
Copy link
Contributor

Pull request #1559 was updated. @civanch, @nclopezo, @vlimant, @ianna, @mdhildreth, @ktf, @cmsbuild, @franzoni, @Dr15Jones, @fabiocos can you please check and sign again.

@vlimant
Copy link
Contributor

vlimant commented Nov 28, 2013

can you please send me a private email directly when you guys reached a
functioning pull ?

Cheers,
Jean-Roch.

On 11/28/13 12:08 PM, cmsbuild wrote:

Pull request #1559 #1559 was
updated. @civanch https://github.com/civanch, @nclopezo
https://github.com/nclopezo, @vlimant https://github.com/vlimant,
@ianna https://github.com/ianna, @mdhildreth
https://github.com/mdhildreth, @ktf https://github.com/ktf,
@cmsbuild https://github.com/cmsbuild, @franzoni
https://github.com/franzoni, @Dr15Jones
https://github.com/Dr15Jones, @fabiocos https://github.com/fabiocos
can you please check and sign again.


Reply to this email directly or view it on GitHub
#1559 (comment).


           ** Dr. Jean-Roch VLIMANT **
   CMS experiment,  CERN - Physics department

CERN Office: 40-3-A28 tel: +41 22 767 1209

CERN CMS Secretariat fax: +41 22 767 8940

@davidlange6
Copy link
Contributor

@ianna - (correctly a private mail a bit) for the moment at least, lets call this geometry (for cmsDriver purposes at least) Extended2023PFCal or Extended2023HGCal - presumably we will "soon" have several of these and this way its clear from the name what calorimeter is used. (will also need a "default" Extended2023, but not that far along yet)

@cmsbuild
Copy link
Contributor

Pull request #1559 was updated. @civanch, @nclopezo, @vlimant, @ianna, @mdhildreth, @ktf, @cmsbuild, @franzoni, @Dr15Jones, @fabiocos can you please check and sign again.

@cmsbuild
Copy link
Contributor

Pull request #1559 was updated. @civanch, @nclopezo, @vlimant, @ianna, @mdhildreth, @ktf, @cmsbuild, @franzoni, @Dr15Jones, @fabiocos can you please check and sign again.

@ianna
Copy link
Contributor Author

ianna commented Nov 29, 2013

@vandreev11 - now you have both HGCalEE and HGCalHE defined. Please, use them as parent volumes for pfcal children.

@cmsbuild
Copy link
Contributor

Pull request #1559 was updated. @civanch, @nclopezo, @vlimant, @ianna, @mdhildreth, @ktf, @cmsbuild, @franzoni, @Dr15Jones, @fabiocos can you please check and sign again.

@cmsbuild
Copy link
Contributor

Pull request #1559 was updated. @civanch, @nclopezo, @vlimant, @ianna, @mdhildreth, @ktf, @cmsbuild, @franzoni, @Dr15Jones, @fabiocos can you please check and sign again.

@ianna
Copy link
Contributor Author

ianna commented Nov 29, 2013

@vandreev11 and @pfs - note, the total number of volumes is the same, but there are twice less defined in xml (only ZP). This is due to positioning in HE mother volume, which is then placed twice. The difference is that volume copies are places clockwise looking at end-cap from IP for both +Z and -Z.

@davidlange6 - Please, take it to the next SLHC release. I'll open another branch to fix overlaps in Extended2023 scenario. It will be based on this one.

@ianna
Copy link
Contributor Author

ianna commented Nov 29, 2013

+1

ktf added a commit that referenced this pull request Dec 9, 2013
First version of PFCal geometry description
@ktf ktf merged commit f9c5565 into cms-sw:CMSSW_6_2_X_SLHC Dec 9, 2013
@ianna ianna deleted the pfcalo-geometry branch October 26, 2015 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants