Automatic emap in HCAL hardcode conditions #15606
Conversation
|
A new Pull Request was created by @kpedro88 (Kevin Pedro) for CMSSW_8_1_X. It involves the following packages: CalibCalorimetry/HcalAlgos @ghellwig, @civanch, @cerminar, @cmsbuild, @franzoni, @mdhildreth, @ggovi, @mmusich, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are list here #13028 |
|
@cmsbuild please test |
|
The tests are being triggered in jenkins. |
|
+1 |
|
+1 for changes in |
kpedro88
force-pushed
the
Phase1-DbHardcode2
branch
from
0ed4d52
to
df0c1b3
Compare
|
rebased... @cmsbuild please test |
|
Pull request #15606 was updated. @ghellwig, @civanch, @cerminar, @cmsbuild, @franzoni, @mdhildreth, @ggovi, @mmusich, @davidlange6 can you please check and sign again. |
|
Please test |
|
The tests are being triggered in jenkins. |
|
+1 |
|
+1 |
|
+1 |
cmsbuild
added
simulation-approved
fully-signed
and removed
pending-signatures
simulation-pending
labels
|
This pull request is fully signed and it will be integrated in one of the next CMSSW_8_1_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @smuzaffar |
| @@ -93,7 +93,13 @@ def customise_Hcal2017(process): | |||
| process=customise_mixing(process) | |||
| if hasattr(process,'simHcalTriggerPrimitiveDigis'): | |||
| process.simHcalTriggerPrimitiveDigis.upgradeHF = cms.bool(True) | |||
|
|
|||
| if hasattr(process,'dqmoffline_step'): | |||
There was a problem hiding this comment.
probably more reliable just to check hasattr(process,'digiTask' ) but I presume this is all going away in favor of eras soon...
There was a problem hiding this comment.
Yes, HCalCustoms is just being used for development right now. Hopefully everything will be moved to Eras by pre12.
|
+1 |
This PR introduces an algorithm to assign ElectronicsIds to any collection of HCAL cells (regardless of topology) and thereby create an ElectronicsMap automatically.
There are also a few changes to the interim customizations for HCAL development, which will be removed when the full workflow is ready.
I also fixed the ptr copy problem in
HcalElectronicsMapnoted by @slava77.@deguio looked at the DQM output with the automatic emap (following HcalPhase1SoftwareSimulationRecipe, using the
-voption) and saw sensible results.Still to be done in subsequent PRs:
HcalElectronicsMap