Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add DigiPhase1Task #15663

Merged
merged 1 commit into from Sep 1, 2016
Merged

Conversation

deguio
Copy link
Contributor

@deguio deguio commented Aug 30, 2016

the DigiPhase1Task is now activated in the customise_Hcal2017 scenario. it will go through Eras soon.
the task produces plots for:

  • QIE11Digis for HBHE
  • QIE10Digis for HF

the module doesn't run in any central sequence for now and has been tested following the recipe at:
https://twiki.cern.ch/twiki/bin/viewauth/CMS/HcalPhase1SoftwareSimulationRecipe
plots are available at:
http://cern.ch/go/wcc7

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @deguio (Federico De Guio) for CMSSW_8_1_X.

It involves the following packages:

DQM/HcalTasks
SLHCUpgradeSimulations/Configuration

@civanch, @mdhildreth, @dmitrijus, @cmsbuild, @vanbesien, @davidlange6 can you please review it and eventually sign? Thanks.
@makortel, @Martin-Grunewald this is something you requested to watch as well.
@slava77, @smuzaffar you are the release manager for this.

cms-bot commands are list here #13028

@dmitrijus
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 30, 2016

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/14835/console

@cmsbuild
Copy link
Contributor

@kpedro88
Copy link
Contributor

@deguio in 2017, HB digis will be in the old collection, and HE digis will be in the new QIE11 collection. Will the DQM code handle this properly?

@deguio
Copy link
Contributor Author

deguio commented Aug 31, 2016

Hi Kevin,
from the topology/mapping point of view yes, but for next year changes will come anyway. the loops over the collections will be slightly re-organized.
F.

@civanch
Copy link
Contributor

civanch commented Aug 31, 2016

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_1_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @smuzaffar

@davidlange6
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit a542c90 into cms-sw:CMSSW_8_1_X Sep 1, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants