New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add DigiPhase1Task #15663
add DigiPhase1Task #15663
Conversation
A new Pull Request was created by @deguio (Federico De Guio) for CMSSW_8_1_X. It involves the following packages: DQM/HcalTasks @civanch, @mdhildreth, @dmitrijus, @cmsbuild, @vanbesien, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are list here #13028 |
+1 |
The tests are being triggered in jenkins. |
+1 The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: |
@deguio in 2017, HB digis will be in the old collection, and HE digis will be in the new QIE11 collection. Will the DQM code handle this properly? |
Hi Kevin, |
+1 |
This pull request is fully signed and it will be integrated in one of the next CMSSW_8_1_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @smuzaffar |
+1 |
the DigiPhase1Task is now activated in the customise_Hcal2017 scenario. it will go through Eras soon.
the task produces plots for:
the module doesn't run in any central sequence for now and has been tested following the recipe at:
https://twiki.cern.ch/twiki/bin/viewauth/CMS/HcalPhase1SoftwareSimulationRecipe
plots are available at:
http://cern.ch/go/wcc7