Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to fix late validation plots from PR 15562 #15669

Merged
merged 2 commits into from Sep 12, 2016

Commits on Aug 30, 2016

  1. Fix based on the validation plots. This results from the fact that wh…

    …en CandViewMerger is used, the referening of the packedcandidates to the orignal leptons is somehow broken. PuppiPhoton relies on these references to remove the give pfcandidates assigned to a good photon weight 1. If this is broken Puppi photon will add back the missing candidates even if they are there. The solution is to either run puppi no lepton or puppiphoton, but not both. The problem with this is that puppi vs puppi no lepton will reduce the MET response by a 2-3% whereas puppiphoton vs puppi will make puppiMET robust in photon+jet events. We prfer to have puppi photon. On another note, after miniAOD is run, the puppinolepton weights attached to the packed candidates give weight 1 for the leptons, so puppiphoton can be run on the miniAOD using the precomputed puppinolepton weights allowing for the best puppiMET peformance.
    violatingcp committed Aug 30, 2016
    Copy the full SHA
    016ba70 View commit details
    Browse the repository at this point in the history

Commits on Sep 8, 2016

  1. updated the Puppi Photon code to not necessarily rely on references a…

    …nd rather do a delta R matching to the candidates. This allows for use on Reco and and Puppi NoLepton collections without directly relying on the references to fix things. This is a result of studies which show that using the collection puppiMerged or the reco Puppi candidates breaks the use of referene keys to link things making Delta R the only option. The reco code is thus updated with what should be the BEST puppi MET version. However the validated version consists of commenting out the puppiMerged line
    violatingcp committed Sep 8, 2016
    Copy the full SHA
    b92cdaa View commit details
    Browse the repository at this point in the history