Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bsunanda:Run2-hcx91 Change TriggerMode definition #15679

Merged
merged 1 commit into from Sep 6, 2016

Conversation

bsunanda
Copy link
Contributor

No description provided.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @bsunanda for CMSSW_8_1_X.

It involves the following packages:

Geometry/CaloTopology
Geometry/HcalCommonData
Geometry/HcalTowerAlgo

@civanch, @Dr15Jones, @ianna, @mdhildreth, @cmsbuild, @davidlange6 can you please review it and eventually sign? Thanks.
@ghellwig this is something you requested to watch as well.
@slava77, @smuzaffar you are the release manager for this.

cms-bot commands are list here #13028

@bsunanda
Copy link
Contributor Author

@cmsbuild Please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 31, 2016

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/14868/console

@cmsbuild
Copy link
Contributor

-1

Tested at: e7bc2cd

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-15679/14868/summary.html

I found follow errors while testing this PR

Failed tests: RelVals

  • RelVals:

When I ran the RelVals I found an error in the following worklfows:
136.731 step1

DAS Error

@bsunanda
Copy link
Contributor Author

bsunanda commented Sep 1, 2016

@cmsbuild Please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 1, 2016

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/14881/console

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 1, 2016

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 1, 2016

@bsunanda
Copy link
Contributor Author

bsunanda commented Sep 2, 2016

@ianna Could you approve this?

@bsunanda
Copy link
Contributor Author

bsunanda commented Sep 5, 2016

@ianna Could you approve this

@ianna
Copy link
Contributor

ianna commented Sep 5, 2016

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 5, 2016

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_1_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @smuzaffar

@davidlange6
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 6d5e42c into cms-sw:CMSSW_8_1_X Sep 6, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants