Bugfix in SiStrip Calibration Code

[suchandradutta]

Bug Fix (forward porting PR #15685 in 81X) : When removing the SiStripDetID dependence from the SiStripDepRecords in PR #8668669 the records were produced incorrectly. In particular, the FakeESSources should be dependent on the TrackerTopologyRcd and not the IdealGeometryRcd. Furthermore, these records are now of the type DependentRecordImplementation instead of EventSetupRecordImplementation. Now the records correctly defined and getting filled properly.
(corresponding code is not used in any production workflow)
@boudoul @jlagram @dimattia @nickmccoll @venturia

[cmsbuild]

A new Pull Request was created by @suchandradutta (Suchandra Dutta) for CMSSW_8_1_X.

It involves the following packages:

CalibTracker/Records
CalibTracker/SiStripESProducers
CondFormats/DataRecord

@ghellwig, @cerminar, @cmsbuild, @franzoni, @ggovi, @mmusich, @davidlange6 can you please review it and eventually sign? Thanks.
@ghellwig, @apfeiffer1, @gbenelli, @tocheng, @jlagram this is something you requested to watch as well.
@slava77, @smuzaffar you are the release manager for this.

cms-bot commands are list here #13028

[mmusich]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/14883/console

[cmsbuild]

+1
Tested at: f935d8c
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-15692/14883/summary.html

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-15692/14883/summary.html

[mmusich]

+1

[davidlange6]

@mmusich - is there any possible impact on the db side from this PR? @ggovi seems not signing it quickly

[ggovi]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_1_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @smuzaffar

[davidlange6]

+1