[Tau]: add parameter to isolation module #15707
Conversation
…f tau combined isolation
|
A new Pull Request was created by @rmanzoni (Riccardo Manzoni) for CMSSW_8_1_X. It involves the following packages: RecoTauTag/RecoTau @cmsbuild, @cvuosalo, @slava77, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are list here #13028 |
|
@cmsbuild please test |
|
The tests are being triggered in jenkins. |
|
@cmsbuild please test |
|
The tests are being triggered in jenkins. |
|
-1 Tested at: 5fec682 You can see the results of the tests here: I found follow errors while testing this PR Failed tests: RelVals
When I ran the RelVals I found an error in the following worklfows: runTheMatrix-results/11224.0_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2023D3_GenSimFull+DigiFull_2023D3+RecoFullGlobal_2023D3+HARVESTFullGlobal_2023D3/step3_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2023D3_GenSimFull+DigiFull_2023D3+RecoFullGlobal_2023D3+HARVESTFullGlobal_2023D3.log |
|
-1 Tested at: 5fec682 You can see the results of the tests here: I found follow errors while testing this PR Failed tests: RelVals
When I ran the RelVals I found an error in the following worklfows: runTheMatrix-results/11224.0_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2023D3_GenSimFull+DigiFull_2023D3+RecoFullGlobal_2023D3+HARVESTFullGlobal_2023D3/step3_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2023D3_GenSimFull+DigiFull_2023D3+RecoFullGlobal_2023D3+HARVESTFullGlobal_2023D3.log |
|
@cmsbuild please test |
|
The tests are being triggered in jenkins. |
|
Seems this one is meant to be approved since the 80x version is signed. |
| // RIC: multiply neutral isolation by a flat factor. | ||
| // Useful, for instance, to combine charged and neutral isolations | ||
| // with different relative weights | ||
| weightGammas_ = pset.exists("WeightECALIsolation") ? |
There was a problem hiding this comment.
This module really should be switched to use fillDescriptions.
|
@rmanzoni: I did not know that this PR was urgent. For future reference, you can use the "urgent" command to mark a PR as urgent so that it gets more expedited review, or you can mention the urgency in the PR description. |
|
+1 Adding weight parameter for tau isolation, with a default value of 1 that has no effect. There should be no change in monitored quantities. #15708 is the 80X version of this PR, and it has already been merged. The code changes are satisfactory, and Jenkins tests against baseline CMSSW_8_1_X_2016-09-04-0000 show no significant differences, as expected. |
cmsbuild
added
fully-signed
reconstruction-approved
and removed
pending-signatures
reconstruction-pending
labels
|
This pull request is fully signed and it will be integrated in one of the next CMSSW_8_1_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @smuzaffar |
|
@cvuosalo ok, thank you for the tip, good to know. |
WeightECALIsolationforRecoTauTag/RecoTau/plugins/PFRecoTauDiscriminationByIsolation.cchttps://indico.cern.ch/event/546904/contributions/2218494/subcontributions/199662/attachments/1329420/1997233/trigger_iso_study.pdf
pset.existsplus default in_cfirather thanfillDescriptionsjust to stick to the current style of the module. There's a work ongoing in the Tau POG to migrate all (many) modules tofillDecriptionsso I haven't interfered.