Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Phase1 Pixel DQM Booking changes and GUI markers #15719

Merged

Conversation

schneiml
Copy link
Contributor

@schneiml schneiml commented Sep 3, 2016

This PR contains a number of different changes that accumulated over time.

  • The main one is a slight restructuring in the booking process. This allows correctly computing the axis ranges for many more 2D plots (main application are 2D maps per layer, where ladder counts vary per layer). I am not happy with what the code looks like now, but it seems unlikely there is a simpler solution.
  • With this change, it also makes sense to add ROCs to the booking process. No real usages now, but 2D maps with ROC granularity will come. Main drawback here is that it slows down the booking process 4x. But if we figure out it is to slow, there is loads of low-hanging fruit to make it faster.
  • There was a problem with how plugins were declared in the SiPixelPhase1Common package. It was pure luck that this worked before, it should be fixed now.
  • There is an experimental version of a plot that was recently added to the Phase0 DQM. Not really useful yet, but it uncovered above problem.
  • The CMSSW side support for adding blue layer/shell/etc. separator lines to the DQM gui is finally added here. To work, this needs support in the DQM GUI, which is merged already and should appear with the September release. W/o this support, the plot labels will look bit messed up, but by the time this code makes it to the RelVals the GUI should also have it.

(also @fioriNTU @davidcarbonis @lunik1 )

Needs a lot of extra code to track metadata, due to TH1 limitiations
(resize after construction basically impossible), even though not
much changes in terms of logic.

Still buggy with ROCs (should be included in booking).
Start Markers with 0; easier to interpret in the plugin.
@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 3, 2016

A new Pull Request was created by @schneiml (Marcel Schneider) for CMSSW_8_1_X.

It involves the following packages:

DQM/SiPixelPhase1Common
DQM/SiPixelPhase1Digis

@cmsbuild, @dmitrijus, @vanbesien, @davidlange6 can you please review it and eventually sign? Thanks.
@idebruyn, @threus, @fioriNTU, @hdelanno this is something you requested to watch as well.
@slava77, @smuzaffar you are the release manager for this.

cms-bot commands are list here #13028

@dmitrijus
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 6, 2016

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/14968/console

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 6, 2016

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_1_X IBs after it passes the integration tests. This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @smuzaffar

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 6, 2016

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 6, 2016

@davidlange6
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 239108b into cms-sw:CMSSW_8_1_X Sep 6, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants