New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Phase1 Pixel DQM Booking changes and GUI markers #15719
Phase1 Pixel DQM Booking changes and GUI markers #15719
Conversation
Needs a lot of extra code to track metadata, due to TH1 limitiations (resize after construction basically impossible), even though not much changes in terms of logic. Still buggy with ROCs (should be included in booking).
Start Markers with 0; easier to interpret in the plugin.
A new Pull Request was created by @schneiml (Marcel Schneider) for CMSSW_8_1_X. It involves the following packages: DQM/SiPixelPhase1Common @cmsbuild, @dmitrijus, @vanbesien, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are list here #13028 |
+1 |
The tests are being triggered in jenkins. |
This pull request is fully signed and it will be integrated in one of the next CMSSW_8_1_X IBs after it passes the integration tests. This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @smuzaffar |
+1 |
This PR contains a number of different changes that accumulated over time.
(also @fioriNTU @davidcarbonis @lunik1 )