New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PostLS2 beampipe for Phase2 #15738
PostLS2 beampipe for Phase2 #15738
Conversation
A new Pull Request was created by @kpedro88 (Kevin Pedro) for CMSSW_8_1_X. It involves the following packages: Configuration/Geometry @civanch, @Dr15Jones, @ianna, @mdhildreth, @cmsbuild, @franzoni, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are list here #13028 |
@cmsbuild please test |
The tests are being triggered in jenkins. |
+1 |
+1 |
@davidlange6 @Dr15Jones let me know if you have a better way to remove an EDAlias with Eras |
also @civanch can you check if Castor needs to be disabled manually in the SIM step, even when the sensitive volume is removed? |
Thanks . I about to take a plane so probably not before tomorrow. .. -------- Original message -------- @boudoulhttps://github.com/boudoul FYI, now that this is merged (should show up in 2300 IB), #15662#15662 needs to be rebased - make sure you regenerate the D4 geometry file from the script so it picks up the changes here. — |
@boudoul that's okay, there may be another conflicting PR by then :) |
Yeah I know ☺ no problem. -------- Original message -------- @boudoulhttps://github.com/boudoul that's okay, there may be another conflicting PR by then :) — |
This PR uses the postLS2 beampipe introduced in #15693 for the Phase2 geometries. Correspondingly, Castor and Totem are removed from the geometries. The removal of Castor requires several customizations, which are added to the
phase2_common
Era.I also did a bit of reorganization in
Configuration/Geometry
based on an earlier comment from @ianna.Unfortunately, I could not figure out a nice way to get Eras to remove EDAlias modules, so the deprecated
isChosen
feature is used for now.@boudoul, this will conflict with #15662, so one of us will have to rebase at some point.