Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PostLS2 beampipe for Phase2 #15738

Merged
merged 3 commits into from Sep 12, 2016
Merged

Conversation

kpedro88
Copy link
Contributor

@kpedro88 kpedro88 commented Sep 5, 2016

This PR uses the postLS2 beampipe introduced in #15693 for the Phase2 geometries. Correspondingly, Castor and Totem are removed from the geometries. The removal of Castor requires several customizations, which are added to the phase2_common Era.

I also did a bit of reorganization in Configuration/Geometry based on an earlier comment from @ianna.

Unfortunately, I could not figure out a nice way to get Eras to remove EDAlias modules, so the deprecated isChosen feature is used for now.

@boudoul, this will conflict with #15662, so one of us will have to rebase at some point.

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 5, 2016

A new Pull Request was created by @kpedro88 (Kevin Pedro) for CMSSW_8_1_X.

It involves the following packages:

Configuration/Geometry
Configuration/StandardSequences
Geometry/CMSCommonData
SimGeneral/MixingModule

@civanch, @Dr15Jones, @ianna, @mdhildreth, @cmsbuild, @franzoni, @davidlange6 can you please review it and eventually sign? Thanks.
@ghellwig, @wmtan, @makortel, @GiacomoSguazzoni, @rovere, @VinInn, @Martin-Grunewald, @dgulhan this is something you requested to watch as well.
@slava77, @smuzaffar you are the release manager for this.

cms-bot commands are list here #13028

@kpedro88
Copy link
Contributor Author

kpedro88 commented Sep 5, 2016

@cmsbuild please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 5, 2016

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/14954/console

@ianna
Copy link
Contributor

ianna commented Sep 5, 2016

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 5, 2016

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 6, 2016

@civanch
Copy link
Contributor

civanch commented Sep 6, 2016

+1

@kpedro88 kpedro88 changed the title PostL2 beampipe for Phase2 PostLS2 beampipe for Phase2 Sep 6, 2016
@kpedro88
Copy link
Contributor Author

kpedro88 commented Sep 8, 2016

@davidlange6 @Dr15Jones let me know if you have a better way to remove an EDAlias with Eras

@kpedro88
Copy link
Contributor Author

kpedro88 commented Sep 8, 2016

also @civanch can you check if Castor needs to be disabled manually in the SIM step, even when the sensitive volume is removed?

@davidlange6
Copy link
Contributor

@kpedro88 - no answer from @civanch it seems - I think your change to the digi step is sufficient here (and there are no complaints in the log). Will merge and let @civanch catch up if needed.

@davidlange6 davidlange6 merged commit ec076f0 into cms-sw:CMSSW_8_1_X Sep 12, 2016
@kpedro88
Copy link
Contributor Author

@boudoul FYI, now that this is merged (should show up in 2300 IB), #15662 needs to be rebased - make sure you regenerate the D4 geometry file from the script so it picks up the changes here.

@boudoul
Copy link
Contributor

boudoul commented Sep 12, 2016

Thanks . I about to take a plane so probably not before tomorrow. ..

-------- Original message --------
From: Kevin Pedro notifications@github.com
Date: 12/09/2016 15:45 (GMT+01:00)
To: cms-sw/cmssw cmssw@noreply.github.com
Cc: Gaelle Boudoul gaelle.boudoul@cern.ch, Mention mention@noreply.github.com
Subject: Re: [cms-sw/cmssw] PostLS2 beampipe for Phase2 (#15738)

@boudoulhttps://github.com/boudoul FYI, now that this is merged (should show up in 2300 IB), #15662#15662 needs to be rebased - make sure you regenerate the D4 geometry file from the script so it picks up the changes here.


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com//pull/15738#issuecomment-246351459, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AE5NyBi2e8-bnNITuukYp1selWbebYV4ks5qpVdogaJpZM4J1Tq-.

@kpedro88
Copy link
Contributor Author

@boudoul that's okay, there may be another conflicting PR by then :)

@boudoul
Copy link
Contributor

boudoul commented Sep 12, 2016

Yeah I know ☺ no problem.

-------- Original message --------
From: Kevin Pedro notifications@github.com
Date: 12/09/2016 15:52 (GMT+01:00)
To: cms-sw/cmssw cmssw@noreply.github.com
Cc: Gaelle Boudoul gaelle.boudoul@cern.ch, Mention mention@noreply.github.com
Subject: Re: [cms-sw/cmssw] PostLS2 beampipe for Phase2 (#15738)

@boudoulhttps://github.com/boudoul that's okay, there may be another conflicting PR by then :)


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com//pull/15738#issuecomment-246353448, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AE5NyF9MBYOcQL5WvNMIgABvxe3j_QrKks5qpVj_gaJpZM4J1Tq-.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants